| Message ID | 20230207075115.1525-9-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | error: Reduce qerror.h usage a bit more | expand |
Markus Armbruster <armbru@redhat.com> wrote: > slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED. > This macro never existed. The reference got added in commit > e3d4d25206a "guest agent: add guest agent RPCs/commands" along with > QERR_QGA_LOGGING_FAILED, so maybe that one was meant. However, > QERR_QGA_LOGGING_FAILED was never actually used, and was removed in > commit d73f0beadb5 "qerror.h: Remove unused error classes". > > Drop the dangling reference. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com> On Tue, Feb 7, 2023 at 10:53 AM Juan Quintela <quintela@redhat.com> wrote: > Markus Armbruster <armbru@redhat.com> wrote: > > slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED. > > This macro never existed. The reference got added in commit > > e3d4d25206a "guest agent: add guest agent RPCs/commands" along with > > QERR_QGA_LOGGING_FAILED, so maybe that one was meant. However, > > QERR_QGA_LOGGING_FAILED was never actually used, and was removed in > > commit d73f0beadb5 "qerror.h: Remove unused error classes". > > > > Drop the dangling reference. > > > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > > Reviewed-by: Juan Quintela <quintela@redhat.com> > >
diff --git a/qga/commands.c b/qga/commands.c index 360077364e..172826f8f8 100644 --- a/qga/commands.c +++ b/qga/commands.c @@ -32,9 +32,8 @@ #define GUEST_FILE_READ_COUNT_MAX (48 * MiB) /* Note: in some situations, like with the fsfreeze, logging may be - * temporarilly disabled. if it is necessary that a command be able - * to log for accounting purposes, check ga_logging_enabled() beforehand, - * and use the QERR_QGA_LOGGING_DISABLED to generate an error + * temporarily disabled. if it is necessary that a command be able + * to log for accounting purposes, check ga_logging_enabled() beforehand. */ void slog(const gchar *fmt, ...) {
slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED. This macro never existed. The reference got added in commit e3d4d25206a "guest agent: add guest agent RPCs/commands" along with QERR_QGA_LOGGING_FAILED, so maybe that one was meant. However, QERR_QGA_LOGGING_FAILED was never actually used, and was removed in commit d73f0beadb5 "qerror.h: Remove unused error classes". Drop the dangling reference. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qga/commands.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)