diff mbox series

[01/23] block: Make bdrv_can_set_read_only() static

Message ID 20230203152202.49054-2-kwolf@redhat.com
State New
Headers show
Series block: Lock the graph, part 2 (BlockDriver callbacks) | expand

Commit Message

Kevin Wolf Feb. 3, 2023, 3:21 p.m. UTC 
It is never called outside of block.c.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 include/block/block-io.h | 2 --
 block.c                  | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

Comments

Vladimir Sementsov-Ogievskiy Feb. 22, 2023, 4:27 p.m. UTC | #1 
On 03.02.23 18:21, Kevin Wolf wrote:
> It is never called outside of block.c.
> 
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
diff mbox series

Patch

diff --git a/include/block/block-io.h b/include/block/block-io.h
index 614cbd7eda..f9fa88204d 100644
--- a/include/block/block-io.h
+++ b/include/block/block-io.h
@@ -134,8 +134,6 @@  int bdrv_is_allocated_above(BlockDriverState *top, BlockDriverState *base,
 int coroutine_fn bdrv_co_is_zero_fast(BlockDriverState *bs, int64_t offset,
                                       int64_t bytes);
 
-int bdrv_can_set_read_only(BlockDriverState *bs, bool read_only,
-                           bool ignore_allow_rdw, Error **errp);
 int bdrv_apply_auto_read_only(BlockDriverState *bs, const char *errmsg,
                               Error **errp);
 bool bdrv_is_read_only(BlockDriverState *bs);
diff --git a/block.c b/block.c
index 122aa9a9ac..c2a8d66f75 100644
--- a/block.c
+++ b/block.c
@@ -277,8 +277,8 @@  bool bdrv_is_read_only(BlockDriverState *bs)
     return !(bs->open_flags & BDRV_O_RDWR);
 }
 
-int bdrv_can_set_read_only(BlockDriverState *bs, bool read_only,
-                           bool ignore_allow_rdw, Error **errp)
+static int bdrv_can_set_read_only(BlockDriverState *bs, bool read_only,
+                                  bool ignore_allow_rdw, Error **errp)
 {
     IO_CODE();