| Message ID | 20230122153307.1050593-1-kfir@daynix.com |
|---|---|
| State | New |
| Headers | show |
| Series | qga/linux: add usb support to guest-get-fsinfo | expand |
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com> On Sun, Jan 22, 2023 at 5:33 PM Kfir Manor <kfir@daynix.com> wrote: > --- > qga/commands-posix.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index ebd33a643c..aab9d3bd50 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const > *syspath, > g_str_equal(driver, "sym53c8xx") || > g_str_equal(driver, "virtio-pci") || > g_str_equal(driver, "ahci") || > - g_str_equal(driver, "nvme"))) { > + g_str_equal(driver, "nvme") || > + g_str_equal(driver, "xhci_hcd") || > + g_str_equal(driver, "ehci-pci"))) { > break; > } > > @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const > *syspath, > } > } else if (strcmp(driver, "nvme") == 0) { > disk->bus_type = GUEST_DISK_BUS_TYPE_NVME; > + } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver, > "xhci_hcd") == 0) { > + disk->bus_type = GUEST_DISK_BUS_TYPE_USB; > } else { > g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath); > goto cleanup; > -- > 2.38.1 > >
Hi Kfir, You missed adding the Signed-off-by line to the patch. Please resend. Best Regards, Konstantin Kostiuk. On Sun, Jan 22, 2023 at 5:33 PM Kfir Manor <kfir@daynix.com> wrote: > --- > qga/commands-posix.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index ebd33a643c..aab9d3bd50 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const > *syspath, > g_str_equal(driver, "sym53c8xx") || > g_str_equal(driver, "virtio-pci") || > g_str_equal(driver, "ahci") || > - g_str_equal(driver, "nvme"))) { > + g_str_equal(driver, "nvme") || > + g_str_equal(driver, "xhci_hcd") || > + g_str_equal(driver, "ehci-pci"))) { > break; > } > > @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const > *syspath, > } > } else if (strcmp(driver, "nvme") == 0) { > disk->bus_type = GUEST_DISK_BUS_TYPE_NVME; > + } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver, > "xhci_hcd") == 0) { > + disk->bus_type = GUEST_DISK_BUS_TYPE_USB; > } else { > g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath); > goto cleanup; > -- > 2.38.1 > >
diff --git a/qga/commands-posix.c b/qga/commands-posix.c index ebd33a643c..aab9d3bd50 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const *syspath, g_str_equal(driver, "sym53c8xx") || g_str_equal(driver, "virtio-pci") || g_str_equal(driver, "ahci") || - g_str_equal(driver, "nvme"))) { + g_str_equal(driver, "nvme") || + g_str_equal(driver, "xhci_hcd") || + g_str_equal(driver, "ehci-pci"))) { break; } @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const *syspath, } } else if (strcmp(driver, "nvme") == 0) { disk->bus_type = GUEST_DISK_BUS_TYPE_NVME; + } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver, "xhci_hcd") == 0) { + disk->bus_type = GUEST_DISK_BUS_TYPE_USB; } else { g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath); goto cleanup;