diff mbox series

[2/3] tests/qtest/vnc-display-test: Use the 'none' machine

Message ID 20230119120514.28778-3-philmd@linaro.org
State New
Headers show
Series tests/qtest/vnc-display-test: Silent warnings & explicit machine | expand

Commit Message

Philippe Mathieu-Daudé Jan. 19, 2023, 12:05 p.m. UTC 
If we don't specify any machine, an architecture default
might be picked. But some architectures don't provide any
default, such ARM:

  $ make check-qtest-aarch64
  ...
  19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test
  qemu-system-aarch64: No machine specified, and there is no default

Since we don't need any particular machine to run this VNC
test, use the 'none' machine.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 tests/qtest/vnc-display-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabiano Rosas Jan. 19, 2023, 12:27 p.m. UTC | #1 
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> If we don't specify any machine, an architecture default
> might be picked. But some architectures don't provide any
> default, such ARM:
>
>   $ make check-qtest-aarch64
>   ...
>   19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test
>   qemu-system-aarch64: No machine specified, and there is no default
>
> Since we don't need any particular machine to run this VNC
> test, use the 'none' machine.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Richard Henderson Jan. 19, 2023, 8:23 p.m. UTC | #2 
On 1/19/23 02:05, Philippe Mathieu-Daudé wrote:
> If we don't specify any machine, an architecture default
> might be picked. But some architectures don't provide any
> default, such ARM:
> 
>    $ make check-qtest-aarch64
>    ...
>    19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test
>    qemu-system-aarch64: No machine specified, and there is no default
> 
> Since we don't need any particular machine to run this VNC
> test, use the 'none' machine.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   tests/qtest/vnc-display-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
diff mbox series

Patch

diff --git a/tests/qtest/vnc-display-test.c b/tests/qtest/vnc-display-test.c
index fd63e3a881..df468c7b22 100644
--- a/tests/qtest/vnc-display-test.c
+++ b/tests/qtest/vnc-display-test.c
@@ -44,7 +44,7 @@  test_setup(Test *test)
 #else
     int pair[2];
 
-    test->qts = qtest_init("-vnc none -name vnc-test");
+    test->qts = qtest_init("-M none -vnc none -name vnc-test");
 
     g_assert_cmpint(qemu_socketpair(AF_UNIX, SOCK_STREAM, 0, pair), ==, 0);