Message ID | 20230112191454.169353-4-kwolf@redhat.com |
---|---|
State | New |
Headers | show |
Series | qemu-img: Fix exit code for errors closing the image | expand |
On 12/1/23 20:14, Kevin Wolf wrote: > blk_unref() can't report any errors that happen while closing the image. > For example, if qcow2 hits an -ENOSPC error while writing out dirty > bitmaps when it's closed, it prints error messages to stderr, but > 'qemu-img bitmap' won't see any error return value and will therefore > look successful with exit code 0. > > In order to fix this, manually inactivate the image first before calling > blk_unref(). This already performs the operations that would be most > likely to fail while closing the image, but it can still return errors. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1330 > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > qemu-img.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/qemu-img.c b/qemu-img.c index 22d6ecefd5..c3671d4890 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4645,6 +4645,7 @@ static int img_bitmap(int argc, char **argv) QSIMPLEQ_HEAD(, ImgBitmapAction) actions; ImgBitmapAction *act, *act_next; const char *op; + int inactivate_ret; QSIMPLEQ_INIT(&actions); @@ -4829,6 +4830,16 @@ static int img_bitmap(int argc, char **argv) ret = 0; out: + /* + * Manually inactivate the images first because this way we can know whether + * an error occurred. blk_unref() doesn't tell us about failures. + */ + inactivate_ret = bdrv_inactivate_all(); + if (inactivate_ret < 0) { + error_report("Error while closing the image: %s", strerror(-inactivate_ret)); + ret = 1; + } + blk_unref(src); blk_unref(blk); qemu_opts_del(opts);
blk_unref() can't report any errors that happen while closing the image. For example, if qcow2 hits an -ENOSPC error while writing out dirty bitmaps when it's closed, it prints error messages to stderr, but 'qemu-img bitmap' won't see any error return value and will therefore look successful with exit code 0. In order to fix this, manually inactivate the image first before calling blk_unref(). This already performs the operations that would be most likely to fail while closing the image, but it can still return errors. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1330 Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- qemu-img.c | 11 +++++++++++ 1 file changed, 11 insertions(+)