diff mbox series

[v5,2/4] python/qmp: increase read buffer size

Message ID 20230112152805.33109-3-davydov-max@yandex-team.ru
State New
Headers show
Series compare machine type compat_props | expand

Commit Message

Maksim Davydov Jan. 12, 2023, 3:28 p.m. UTC
Current 256KB is not enough for some real cases. As a possible solution
limit can be chosen to be the same as libvirt (10MB)

Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru>
Reviewed-by: John Snow <jsnow@redhat.com>
---
 python/qemu/qmp/qmp_client.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

John Snow Jan. 17, 2023, 10:42 p.m. UTC | #1
On Thu, Jan 12, 2023 at 10:28 AM Maksim Davydov
<davydov-max@yandex-team.ru> wrote:
>
> Current 256KB is not enough for some real cases. As a possible solution
> limit can be chosen to be the same as libvirt (10MB)
>
> Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
>  python/qemu/qmp/qmp_client.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/python/qemu/qmp/qmp_client.py b/python/qemu/qmp/qmp_client.py
> index 5dcda04a75..b5772e7f32 100644
> --- a/python/qemu/qmp/qmp_client.py
> +++ b/python/qemu/qmp/qmp_client.py
> @@ -197,8 +197,8 @@ async def run(self, address='/tmp/qemu.socket'):
>      #: Logger object used for debugging messages.
>      logger = logging.getLogger(__name__)
>
> -    # Read buffer limit; large enough to accept query-qmp-schema
> -    _limit = (256 * 1024)
> +    # Read buffer limit; 10MB like libvirt default
> +    _limit = (10 * 1024 * 1024)
>
>      # Type alias for pending execute() result items
>      _PendingT = Union[Message, ExecInterruptedError]
> --
> 2.25.1
>

I've staged this one patch to send with my next Python update.

If by chance this series should be picked up in entirety by another
maintainer before I get this one patch in: Go for it, you've got my
blessing.

Acked-by: John Snow <jsnow@redhat.com>
diff mbox series

Patch

diff --git a/python/qemu/qmp/qmp_client.py b/python/qemu/qmp/qmp_client.py
index 5dcda04a75..b5772e7f32 100644
--- a/python/qemu/qmp/qmp_client.py
+++ b/python/qemu/qmp/qmp_client.py
@@ -197,8 +197,8 @@  async def run(self, address='/tmp/qemu.socket'):
     #: Logger object used for debugging messages.
     logger = logging.getLogger(__name__)
 
-    # Read buffer limit; large enough to accept query-qmp-schema
-    _limit = (256 * 1024)
+    # Read buffer limit; 10MB like libvirt default
+    _limit = (10 * 1024 * 1024)
 
     # Type alias for pending execute() result items
     _PendingT = Union[Message, ExecInterruptedError]