Message ID | 20221214100911.165291-1-thuth@redhat.com |
---|---|
State | New |
Headers | show |
On Wed, 14 Dec 2022 at 10:16, Thomas Huth <thuth@redhat.com> wrote: > > Hi! > > The following changes since commit 5204b499a6cae4dfd9fe762d5e6e82224892383b: > > mailmap: Fix Stefan Weil author email (2022-12-13 15:56:57 -0500) > > are available in the Git repository at: > > https://gitlab.com/thuth/qemu.git tags/pull-request-2022-12-14 > > for you to fetch changes up to 8eeb98e2ea03639e743fdae82ae69d571d8ef0a3: > > tests/qtest/vhost-user-blk-test: don't abort all qtests on missing envar (2022-12-14 08:55:37 +0100) > > ---------------------------------------------------------------- > * s390x PCI fixes and improvements (for the ISM device) > * Fix emulated MVCP and MVCS s390x instructions > * Clean-ups for the e1000e qtest > * Enable qtests on Windows > * Update FreeBSD CI to version 12.4 > * Check --disable-tcg for ppc64 in the CI > * Improve scripts/make-releases a little bit > * Many other misc small clean-ups and fixes here and there Hi; this fails to compile: ../../util/qemu-config.c: In function 'objprop_to_cmdline_prop': ../../util/qemu-config.c:165:13: error: 'CommandLineParameterInfo' has no member named 'has_help' 165 | info->has_help = true; | ^~ ../../util/qemu-config.c: In function 'query_all_machine_properties': ../../util/qemu-config.c:217:9: error: 'CommandLineParameterInfo' has no member named 'has_help' 217 | info->has_help = true; | ^~ I'm afraid your pullreq has crossed in the mail with Markus' QAPI one, which refactored things so these QAPI structs no longer have has_* fields. thanks -- PMM
On 15/12/2022 14.38, Peter Maydell wrote: > On Wed, 14 Dec 2022 at 10:16, Thomas Huth <thuth@redhat.com> wrote: >> >> Hi! >> >> The following changes since commit 5204b499a6cae4dfd9fe762d5e6e82224892383b: >> >> mailmap: Fix Stefan Weil author email (2022-12-13 15:56:57 -0500) >> >> are available in the Git repository at: >> >> https://gitlab.com/thuth/qemu.git tags/pull-request-2022-12-14 >> >> for you to fetch changes up to 8eeb98e2ea03639e743fdae82ae69d571d8ef0a3: >> >> tests/qtest/vhost-user-blk-test: don't abort all qtests on missing envar (2022-12-14 08:55:37 +0100) >> >> ---------------------------------------------------------------- >> * s390x PCI fixes and improvements (for the ISM device) >> * Fix emulated MVCP and MVCS s390x instructions >> * Clean-ups for the e1000e qtest >> * Enable qtests on Windows >> * Update FreeBSD CI to version 12.4 >> * Check --disable-tcg for ppc64 in the CI >> * Improve scripts/make-releases a little bit >> * Many other misc small clean-ups and fixes here and there > > Hi; this fails to compile: > > ../../util/qemu-config.c: In function 'objprop_to_cmdline_prop': > ../../util/qemu-config.c:165:13: error: 'CommandLineParameterInfo' has > no member named 'has_help' > 165 | info->has_help = true; > | ^~ > ../../util/qemu-config.c: In function 'query_all_machine_properties': > ../../util/qemu-config.c:217:9: error: 'CommandLineParameterInfo' has > no member named 'has_help' > 217 | info->has_help = true; > | ^~ > > I'm afraid your pullreq has crossed in the mail with Markus' > QAPI one, which refactored things so these QAPI structs > no longer have has_* fields. Right. Should be easy to fix, I'll send a v2 as soon as I've checked that it compiles fine everywhere... Thomas