| Message ID | 20221208101527.36873-1-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | gitlab-ci: Check building ppc64 without TCG | expand |
On 8/12/22 11:15, Thomas Huth wrote: > Building QEMU for ppc64 hosts with --disable-tcg used to break a couple > of times in the past, see e.g. commit a01b64cee7 ("target/ppc: Put do_rfi > under a TCG-only block") or commit 049b4ad669 ("target/ppc: Fix build > warnings when building with 'disable-tcg'"), so we should test this in > our CI to avoid such regressions. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > Not sure whether we really should add new shared runner jobs ... but > I currently also don't see a better option for this: We don't have > any custom ppc64 runners in our CI, so the only other way to test this > is travis - but the Travis extension for gitlab recently broke, so > the results there are currently rather neglected, I think... > > .gitlab-ci.d/crossbuilds.yml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml > index c4cd96433d..8dbbb8f881 100644 > --- a/.gitlab-ci.d/crossbuilds.yml > +++ b/.gitlab-ci.d/crossbuilds.yml > @@ -112,6 +112,14 @@ cross-ppc64el-user: > variables: > IMAGE: debian-ppc64el-cross > > +cross-ppc64el-kvm-only: > + extends: .cross_accel_build_job > + needs: > + job: ppc64el-debian-cross-container > + variables: > + IMAGE: debian-ppc64el-cross > + EXTRA_CONFIGURE_OPTS: --disable-tcg --without-default-devices Maybe also --disable-tools --disable-docs? Regardless: Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On 08/12/2022 11.17, Philippe Mathieu-Daudé wrote: > On 8/12/22 11:15, Thomas Huth wrote: >> Building QEMU for ppc64 hosts with --disable-tcg used to break a couple >> of times in the past, see e.g. commit a01b64cee7 ("target/ppc: Put do_rfi >> under a TCG-only block") or commit 049b4ad669 ("target/ppc: Fix build >> warnings when building with 'disable-tcg'"), so we should test this in >> our CI to avoid such regressions. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> --- >> Not sure whether we really should add new shared runner jobs ... but >> I currently also don't see a better option for this: We don't have >> any custom ppc64 runners in our CI, so the only other way to test this >> is travis - but the Travis extension for gitlab recently broke, so >> the results there are currently rather neglected, I think... >> >> .gitlab-ci.d/crossbuilds.yml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml >> index c4cd96433d..8dbbb8f881 100644 >> --- a/.gitlab-ci.d/crossbuilds.yml >> +++ b/.gitlab-ci.d/crossbuilds.yml >> @@ -112,6 +112,14 @@ cross-ppc64el-user: >> variables: >> IMAGE: debian-ppc64el-cross >> +cross-ppc64el-kvm-only: >> + extends: .cross_accel_build_job >> + needs: >> + job: ppc64el-debian-cross-container >> + variables: >> + IMAGE: debian-ppc64el-cross >> + EXTRA_CONFIGURE_OPTS: --disable-tcg --without-default-devices > > Maybe also --disable-tools --disable-docs? These are already added by the template. > Regardless: > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Thanks! Thomas
Thomas Huth <thuth@redhat.com> writes: > Building QEMU for ppc64 hosts with --disable-tcg used to break a couple > of times in the past, see e.g. commit a01b64cee7 ("target/ppc: Put do_rfi > under a TCG-only block") or commit 049b4ad669 ("target/ppc: Fix build > warnings when building with 'disable-tcg'"), so we should test this in > our CI to avoid such regressions. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Queued to testing/next, thanks.
diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index c4cd96433d..8dbbb8f881 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -112,6 +112,14 @@ cross-ppc64el-user: variables: IMAGE: debian-ppc64el-cross +cross-ppc64el-kvm-only: + extends: .cross_accel_build_job + needs: + job: ppc64el-debian-cross-container + variables: + IMAGE: debian-ppc64el-cross + EXTRA_CONFIGURE_OPTS: --disable-tcg --without-default-devices + # The riscv64 cross-builds currently use a 'sid' container to get # compilers and libraries. Until something more stable is found we # allow_failure so as not to block CI.
Building QEMU for ppc64 hosts with --disable-tcg used to break a couple of times in the past, see e.g. commit a01b64cee7 ("target/ppc: Put do_rfi under a TCG-only block") or commit 049b4ad669 ("target/ppc: Fix build warnings when building with 'disable-tcg'"), so we should test this in our CI to avoid such regressions. Signed-off-by: Thomas Huth <thuth@redhat.com> --- Not sure whether we really should add new shared runner jobs ... but I currently also don't see a better option for this: We don't have any custom ppc64 runners in our CI, so the only other way to test this is travis - but the Travis extension for gitlab recently broke, so the results there are currently rather neglected, I think... .gitlab-ci.d/crossbuilds.yml | 8 ++++++++ 1 file changed, 8 insertions(+)