diff mbox series

[1/3] block: mention 'password-secret' option for -iscsi

Message ID 20221201101959.419545-2-berrange@redhat.com
State New
Headers show
Series More work on deprecation/removal of clear text passwords | expand

Commit Message

Daniel P. Berrangé Dec. 1, 2022, 10:19 a.m. UTC 
The 'password-secret' option was added

  commit b189346eb1784df95ed6fed610411dbf23d19e1f
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Thu Jan 21 14:19:21 2016 +0000

    iscsi: add support for getting CHAP password via QCryptoSecret API

but was not mentioned in the command line docs

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabiano Rosas Dec. 1, 2022, 12:58 p.m. UTC | #1 
Daniel P. Berrangé <berrange@redhat.com> writes:

> The 'password-secret' option was added
>
>   commit b189346eb1784df95ed6fed610411dbf23d19e1f
>   Author: Daniel P. Berrangé <berrange@redhat.com>
>   Date:   Thu Jan 21 14:19:21 2016 +0000
>
>     iscsi: add support for getting CHAP password via QCryptoSecret API
>
> but was not mentioned in the command line docs
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 7f99d15b23..055df73306 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1889,7 +1889,7 @@ SRST
>  ERST
>  
>  DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
> -    "-iscsi [user=user][,password=password]\n"
> +    "-iscsi [user=user][,password=password],password-secret=secret-id]\n"

Loos like you're missing a bracket before the comma.

The line below also lacks one at the end.

>      "       [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n"
>      "       [,initiator-name=initiator-iqn][,id=target-iqn]\n"
>      "       [,timeout=timeout]\n"
Daniel P. Berrangé Dec. 16, 2022, 11:18 a.m. UTC | #2 
On Thu, Dec 01, 2022 at 09:58:12AM -0300, Fabiano Rosas wrote:
> Daniel P. Berrangé <berrange@redhat.com> writes:
> 
> > The 'password-secret' option was added
> >
> >   commit b189346eb1784df95ed6fed610411dbf23d19e1f
> >   Author: Daniel P. Berrangé <berrange@redhat.com>
> >   Date:   Thu Jan 21 14:19:21 2016 +0000
> >
> >     iscsi: add support for getting CHAP password via QCryptoSecret API
> >
> > but was not mentioned in the command line docs
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  qemu-options.hx | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 7f99d15b23..055df73306 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -1889,7 +1889,7 @@ SRST
> >  ERST
> >  
> >  DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
> > -    "-iscsi [user=user][,password=password]\n"
> > +    "-iscsi [user=user][,password=password],password-secret=secret-id]\n"
> 
> Loos like you're missing a bracket before the comma.
> 
> The line below also lacks one at the end.

Thanks, will fix both.

> 
> >      "       [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n"
> >      "       [,initiator-name=initiator-iqn][,id=target-iqn]\n"
> >      "       [,timeout=timeout]\n"
> 

With regards,
Daniel
diff mbox series

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index 7f99d15b23..055df73306 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1889,7 +1889,7 @@  SRST
 ERST
 
 DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
-    "-iscsi [user=user][,password=password]\n"
+    "-iscsi [user=user][,password=password],password-secret=secret-id]\n"
     "       [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n"
     "       [,initiator-name=initiator-iqn][,id=target-iqn]\n"
     "       [,timeout=timeout]\n"