| Message ID | 20221114135043.2958100-3-j.granados@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add OCP extended log to nvme QEMU | expand |
On Nov 14 14:50, Joel Granados wrote: > The Open Compute Project defines a Datacenter NVMe SSD Spec that sits on > top of the NVMe spec. Additional commands and NVMe behaviors specific for > the Datacenter. This is a preparation patch that introduces an argument to > activate OCP in nvme. > > Signed-off-by: Joel Granados <j.granados@samsung.com> > --- > hw/nvme/nvme.h | 1 + > hw/nvme/subsys.c | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/nvme/nvme.h b/hw/nvme/nvme.h > index 79f5c281c2..aa99c0c57c 100644 > --- a/hw/nvme/nvme.h > +++ b/hw/nvme/nvme.h > @@ -56,6 +56,7 @@ typedef struct NvmeSubsystem { > > struct { > char *nqn; > + bool ocp; > } params; > } NvmeSubsystem; > > diff --git a/hw/nvme/subsys.c b/hw/nvme/subsys.c > index 9d2643678b..ecca28449c 100644 > --- a/hw/nvme/subsys.c > +++ b/hw/nvme/subsys.c > @@ -129,8 +129,8 @@ static void nvme_subsys_realize(DeviceState *dev, Error **errp) > > static Property nvme_subsystem_props[] = { > DEFINE_PROP_STRING("nqn", NvmeSubsystem, params.nqn), > - DEFINE_PROP_END_OF_LIST(), > -}; > + DEFINE_PROP_BOOL("ocp", NvmeSubsystem, params.ocp, false), It is the controller that implements the OCP specification, not the namespace or the subsystem. The parameter should be on the controller device. We discussed that the Get Log Page was subsystem scoped and not namespace scoped, but that is unrelated to this. > + DEFINE_PROP_END_OF_LIST(), }; > > static void nvme_subsys_class_init(ObjectClass *oc, void *data) > { > -- > 2.30.2 > >
On Tue, Nov 15, 2022 at 12:11:50PM +0100, Klaus Jensen wrote: > On Nov 14 14:50, Joel Granados wrote: > > The Open Compute Project defines a Datacenter NVMe SSD Spec that sits on > > top of the NVMe spec. Additional commands and NVMe behaviors specific for > > the Datacenter. This is a preparation patch that introduces an argument to > > activate OCP in nvme. > > > > Signed-off-by: Joel Granados <j.granados@samsung.com> > > --- > > hw/nvme/nvme.h | 1 + > > hw/nvme/subsys.c | 4 ++-- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/hw/nvme/nvme.h b/hw/nvme/nvme.h > > index 79f5c281c2..aa99c0c57c 100644 > > --- a/hw/nvme/nvme.h > > +++ b/hw/nvme/nvme.h > > @@ -56,6 +56,7 @@ typedef struct NvmeSubsystem { > > > > struct { > > char *nqn; > > + bool ocp; > > } params; > > } NvmeSubsystem; > > > > diff --git a/hw/nvme/subsys.c b/hw/nvme/subsys.c > > index 9d2643678b..ecca28449c 100644 > > --- a/hw/nvme/subsys.c > > +++ b/hw/nvme/subsys.c > > @@ -129,8 +129,8 @@ static void nvme_subsys_realize(DeviceState *dev, Error **errp) > > > > static Property nvme_subsystem_props[] = { > > DEFINE_PROP_STRING("nqn", NvmeSubsystem, params.nqn), > > - DEFINE_PROP_END_OF_LIST(), > > -}; > > + DEFINE_PROP_BOOL("ocp", NvmeSubsystem, params.ocp, false), > > It is the controller that implements the OCP specification, not the > namespace or the subsystem. The parameter should be on the controller > device. Makes sense. I'll put the option in hw/nvme/ctrl.c > > We discussed that the Get Log Page was subsystem scoped and not > namespace scoped, but that is unrelated to this. Yep, this was the confusion. Thx for clarifying. > > > + DEFINE_PROP_END_OF_LIST(), }; > > > > static void nvme_subsys_class_init(ObjectClass *oc, void *data) > > { > > -- > > 2.30.2 > > > >
diff --git a/hw/nvme/nvme.h b/hw/nvme/nvme.h index 79f5c281c2..aa99c0c57c 100644 --- a/hw/nvme/nvme.h +++ b/hw/nvme/nvme.h @@ -56,6 +56,7 @@ typedef struct NvmeSubsystem { struct { char *nqn; + bool ocp; } params; } NvmeSubsystem; diff --git a/hw/nvme/subsys.c b/hw/nvme/subsys.c index 9d2643678b..ecca28449c 100644 --- a/hw/nvme/subsys.c +++ b/hw/nvme/subsys.c @@ -129,8 +129,8 @@ static void nvme_subsys_realize(DeviceState *dev, Error **errp) static Property nvme_subsystem_props[] = { DEFINE_PROP_STRING("nqn", NvmeSubsystem, params.nqn), - DEFINE_PROP_END_OF_LIST(), -}; + DEFINE_PROP_BOOL("ocp", NvmeSubsystem, params.ocp, false), + DEFINE_PROP_END_OF_LIST(), }; static void nvme_subsys_class_init(ObjectClass *oc, void *data) {
The Open Compute Project defines a Datacenter NVMe SSD Spec that sits on top of the NVMe spec. Additional commands and NVMe behaviors specific for the Datacenter. This is a preparation patch that introduces an argument to activate OCP in nvme. Signed-off-by: Joel Granados <j.granados@samsung.com> --- hw/nvme/nvme.h | 1 + hw/nvme/subsys.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-)