diff mbox series

[PULL,01/86] bios-tables-test: do not ignore allowed diff list

Message ID 20221031124928.128475-2-mst@redhat.com
State New
Headers show
Series [PULL,01/86] bios-tables-test: do not ignore allowed diff list | expand

Commit Message

Michael S. Tsirkin Oct. 31, 2022, 12:50 p.m. UTC 
we had such a beautiful structure for updating
expected files, designed to keep bisect working.
It turns out that we ignored the result of
the allow list checks unless all tables matched
anyway.

Sigh.

Let's at least make it work going forward.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/qtest/bios-tables-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ani Sinha Oct. 31, 2022, 1:25 p.m. UTC | #1 
On Mon, Oct 31, 2022 at 6:20 PM Michael S. Tsirkin <mst@redhat.com> wrote:

> we had such a beautiful structure for updating
> expected files, designed to keep bisect working.
> It turns out that we ignored the result of
> the allow list checks unless all tables matched
> anyway.
>
> Sigh.
>
> Let's at least make it work going forward.


Don't forget to drop this.


>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  tests/qtest/bios-tables-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c
> b/tests/qtest/bios-tables-test.c
> index e6096e7f73..a72f6ca326 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -458,7 +458,7 @@ static void test_acpi_asl(test_data *data)
>                  "for instructions on how to update expected files.\n",
>                  exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file);
>
> -        all_tables_match = all_tables_match &&
> +        all_tables_match = all_tables_match ||
>              test_acpi_find_diff_allowed(exp_sdt);
>
>          /*
> --
> MST
>
>
Michael S. Tsirkin Oct. 31, 2022, 3:01 p.m. UTC | #2 
On Mon, Oct 31, 2022 at 06:55:04PM +0530, Ani Sinha wrote:
> 
> 
> On Mon, Oct 31, 2022 at 6:20 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> 
>     we had such a beautiful structure for updating
>     expected files, designed to keep bisect working.
>     It turns out that we ignored the result of
>     the allow list checks unless all tables matched
>     anyway.
> 
>     Sigh.
> 
>     Let's at least make it work going forward.
> 
> 
> Don't forget to drop this. 


Ugh. ENOCOFFE. I will re-push without this.

> 
> 
> 
>     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>     ---
>      tests/qtest/bios-tables-test.c | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/
>     bios-tables-test.c
>     index e6096e7f73..a72f6ca326 100644
>     --- a/tests/qtest/bios-tables-test.c
>     +++ b/tests/qtest/bios-tables-test.c
>     @@ -458,7 +458,7 @@ static void test_acpi_asl(test_data *data)
>                      "for instructions on how to update expected files.\n",
>                      exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file);
> 
>     -        all_tables_match = all_tables_match &&
>     +        all_tables_match = all_tables_match ||
>                  test_acpi_find_diff_allowed(exp_sdt);
> 
>              /*
>     --
>     MST
> 
>
diff mbox series

Patch

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index e6096e7f73..a72f6ca326 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -458,7 +458,7 @@  static void test_acpi_asl(test_data *data)
                 "for instructions on how to update expected files.\n",
                 exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file);
 
-        all_tables_match = all_tables_match &&
+        all_tables_match = all_tables_match ||
             test_acpi_find_diff_allowed(exp_sdt);
 
         /*