From patchwork Thu Oct 20 09:16:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1692332 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MtN6g0h4Mz1ygT for ; Thu, 20 Oct 2022 20:47:07 +1100 (AEDT) Received: from localhost ([::1]:57966 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olS8l-00056n-N1 for incoming@patchwork.ozlabs.org; Thu, 20 Oct 2022 05:47:04 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olRhg-000306-Fg for incoming@patchwork.ozlabs.org; Thu, 20 Oct 2022 05:19:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olRfd-0002qG-Kt for qemu-devel@nongnu.org; Thu, 20 Oct 2022 05:16:57 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:35259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olRfb-0005JL-Qw for qemu-devel@nongnu.org; Thu, 20 Oct 2022 05:16:57 -0400 Received: from lenovo-t14s.redhat.com ([82.142.8.70]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N9MlI-1p8lpY1kgO-015Jb0; Thu, 20 Oct 2022 11:16:44 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , xen-devel@lists.xenproject.org, Eric Blake , Stefano Stabellini , Paolo Bonzini , Greg Kurz , Jason Wang , Anthony Perard , Thomas Huth , David Gibson , "Michael S. Tsirkin" , Laurent Vivier , Samuel Thibault , "Dr. David Alan Gilbert" , Paul Durrant , Stefan Weil , Markus Armbruster , Stefano Brivio Subject: [PATCH v12 08/17] net: stream: Don't ignore EINVAL on netdev socket connection Date: Thu, 20 Oct 2022 11:16:15 +0200 Message-Id: <20221020091624.48368-9-lvivier@redhat.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221020091624.48368-1-lvivier@redhat.com> References: <20221020091624.48368-1-lvivier@redhat.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:rAowcpovUx7VZ1182aMugTyHfqst2uG2cFQ5qzJT9yB3oYFUnAT CWbhDc5VvbyU5SN1HObxq+zbVD4kHfvYytcZMATeukaALOIRJRZaYr21CzchiTbx3J7xQOQ GMcBCVfpQ3YpaQPlGDRscahcM+ldA5VmZkGtGINwDglcPDB3B/zFjw21+xDj0iIRm+KRQWh R+l90FLVGfvfvnaoJPMKg== X-UI-Out-Filterresults: notjunk:1;V03:K0:T32DJ/xxkVY=:EQMZ+yfhGZk2VN7S22yqgh nYCFS4LjhklSHZIim+p2fv0N/Cef/OvIhT+WkH/5jZhaLuzibvnaEtGLu+G7KqG1lv4KgHmcm aB66i5zFLXB1KrrjOHGui2d4nfFtvZjLKwyschy8Wdn3MZ2XsJ4fBAYDqzIuPjNTRBv2zjoue pYiZITLtjEFv09gjZXTr5FzcFUtTzB3vDPIsX87EN5pKhYX2gAU42j44LO8Bc9g17oc/QAMhm RlgLbKocTfpXWNpqA4A53C73YWU9nR+ce7Cqcm9nXqY2+15N6z5YNTvo610hvnHQZXDsxkMTH MzeYBuqqR1wgz/2WhSk1CJavDQCnXe0iz7n7agjh4lUAebK7HFIFW1f/U5nsM/uBklzP9GDrE VVE7MrKvr+eyEUNytrdr0QEdmg63NLodzw7nmkkVqT4cmr3z4a8z6zCG22kw1Lp8Csy1p4pXR rV4sEcFv3JamjxjFIS/Q2y1x45rpCX3l/ncXeBjbfLrUjv6I7jZ2sopfvaY2tt4MIRadsdPDr nN4ecJ3nYydXKIFtS/0S8wQI6zquVo83soydFxJMa1xeB9Iv/C9ftSgtMbkJ3szeG3uY6fv2y wh4Ttmh1m9gD/gAGOgHkXCjZoieKuz8VCxq+LM2U5Sfv+nJjjL2kPXgUc3HNNLbrh99poXfWN J+ufOq6BSTgJA4P9vnwDKZEwKxBWS6UUbwM/Hb/MaawrZpLTCSIgEl3sNT+S8pfGxEAyfTTCl xpKLCEiGMjQq5Zs7MDRUI2+QWhG2Q0T92yP0bybsQjbONI48zu6BxStrBsI9QUQK6zocntv9u tOWM3pO Received-SPF: permerror client-ip=212.227.126.187; envelope-from=lvivier@redhat.com; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_FAIL=0.001, SPF_HELO_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Stefano Brivio Other errors are treated as failure by net_stream_client_init(), but if connect() returns EINVAL, we'll fail silently. Remove the related exception. Signed-off-by: Stefano Brivio [lvivier: applied to net/stream.c] Signed-off-by: Laurent Vivier Reviewed-by: Daniel P. Berrangé Reviewed-by: David Gibson Acked-by: Michael S. Tsirkin --- net/stream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/stream.c b/net/stream.c index 0a7e84749a3f..e4388fe7e45c 100644 --- a/net/stream.c +++ b/net/stream.c @@ -360,8 +360,7 @@ static int net_stream_client_init(NetClientState *peer, if (errno == EINTR || errno == EWOULDBLOCK) { /* continue */ } else if (errno == EINPROGRESS || - errno == EALREADY || - errno == EINVAL) { + errno == EALREADY) { break; } else { error_setg_errno(errp, errno, "can't connect socket");