| Message ID | 20221013131304.623740-1-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests/tcg: include CONFIG_PLUGIN in config-host.mak | expand |
Paolo Bonzini <pbonzini@redhat.com> writes: > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > configure | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure b/configure > index f4ff1cf305..a5af9c524f 100755 > --- a/configure > +++ b/configure > @@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak > if test -n "$gdb_bin"; then > echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak > fi > +if test "$plugins" = "yes" ; then > + echo "CONFIG_PLUGIN=y" >> $config_host_mak > +fi Don't we already do that anyway? > > tcg_tests_targets= > for target in $target_list; do
On Thu, Oct 13, 2022 at 10:35 PM Alex Bennée <alex.bennee@linaro.org> wrote: > > > Paolo Bonzini <pbonzini@redhat.com> writes: > > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > > --- > > configure | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/configure b/configure > > index f4ff1cf305..a5af9c524f 100755 > > --- a/configure > > +++ b/configure > > @@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak > > if test -n "$gdb_bin"; then > > echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak > > fi > > +if test "$plugins" = "yes" ; then > > + echo "CONFIG_PLUGIN=y" >> $config_host_mak > > +fi > > Don't we already do that anyway? No, we don't. CONFIG_PLUGIN enables "make test-plugins" and "make plugins" but not the plugin tests in tests/tcg. Paolo
Paolo Bonzini <pbonzini@redhat.com> writes: > On Thu, Oct 13, 2022 at 10:35 PM Alex Bennée <alex.bennee@linaro.org> wrote: >> >> >> Paolo Bonzini <pbonzini@redhat.com> writes: >> >> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> >> > --- >> > configure | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/configure b/configure >> > index f4ff1cf305..a5af9c524f 100755 >> > --- a/configure >> > +++ b/configure >> > @@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak >> > if test -n "$gdb_bin"; then >> > echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak >> > fi >> > +if test "$plugins" = "yes" ; then >> > + echo "CONFIG_PLUGIN=y" >> $config_host_mak >> > +fi >> >> Don't we already do that anyway? > > No, we don't. CONFIG_PLUGIN enables "make test-plugins" and "make > plugins" but not the plugin tests in tests/tcg. Ahh I see. Queued to testing/next, thanks.
diff --git a/configure b/configure index f4ff1cf305..a5af9c524f 100755 --- a/configure +++ b/configure @@ -2474,6 +2474,9 @@ echo "HOST_CC=$host_cc" >> $config_host_mak if test -n "$gdb_bin"; then echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak fi +if test "$plugins" = "yes" ; then + echo "CONFIG_PLUGIN=y" >> $config_host_mak +fi tcg_tests_targets= for target in $target_list; do
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- configure | 3 +++ 1 file changed, 3 insertions(+)