| Message ID | 20220925113032.1949844-18-bmeng.cn@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests/qtest: Enable running qtest on Windows | expand |
On Sun, Sep 25, 2022 at 3:59 PM Bin Meng <bmeng.cn@gmail.com> wrote: > From: Bin Meng <bin.meng@windriver.com> > > This case was written to use hardcoded /tmp directory for temporary > files. Update to use g_get_tmp_dir() for a portable implementation. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > > Changes in v3: > - Split to a separate patch > > tests/qtest/vhost-user-blk-test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/qtest/vhost-user-blk-test.c > b/tests/qtest/vhost-user-blk-test.c > index a81c2a2715..07a4c2d500 100644 > --- a/tests/qtest/vhost-user-blk-test.c > +++ b/tests/qtest/vhost-user-blk-test.c > @@ -841,7 +841,8 @@ static char *create_listen_socket(int *fd) > char *path; > > /* No race because our pid makes the path unique */ > - path = g_strdup_printf("/tmp/qtest-%d-sock.XXXXXX", getpid()); > + path = g_strdup_printf("%s/qtest-%d-sock.XXXXXX", > + g_get_tmp_dir(), getpid()); > tmp_fd = mkstemp(path); > g_assert_cmpint(tmp_fd, >=, 0); > close(tmp_fd); > -- > 2.34.1 > > >
diff --git a/tests/qtest/vhost-user-blk-test.c b/tests/qtest/vhost-user-blk-test.c index a81c2a2715..07a4c2d500 100644 --- a/tests/qtest/vhost-user-blk-test.c +++ b/tests/qtest/vhost-user-blk-test.c @@ -841,7 +841,8 @@ static char *create_listen_socket(int *fd) char *path; /* No race because our pid makes the path unique */ - path = g_strdup_printf("/tmp/qtest-%d-sock.XXXXXX", getpid()); + path = g_strdup_printf("%s/qtest-%d-sock.XXXXXX", + g_get_tmp_dir(), getpid()); tmp_fd = mkstemp(path); g_assert_cmpint(tmp_fd, >=, 0); close(tmp_fd);