| Message ID | 20220919131723.73749-1-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | build: remove extra parentheses causing missing rebuilds | expand |
On 9/19/22 15:17, Paolo Bonzini wrote: > Because of two stray parentheses at the end of the definition of > ninja-cmd-goals, the test that is last in the .check-TESTSUITENAME.deps > variable will not be rebuilt. Fix that. > > Signed-off-by: Paolo Bonzini<pbonzini@redhat.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/Makefile b/Makefile index 13234f2aa4..b576cba5a8 100644 --- a/Makefile +++ b/Makefile @@ -145,7 +145,7 @@ NINJAFLAGS = $(if $V,-v) $(if $(MAKE.n), -n) $(if $(MAKE.k), -k0) \ $(filter-out -j, $(lastword -j1 $(filter -l% -j%, $(MAKEFLAGS)))) \ -d keepdepfile ninja-cmd-goals = $(or $(MAKECMDGOALS), all) -ninja-cmd-goals += $(foreach g, $(MAKECMDGOALS), $(.ninja-goals.$g)))) +ninja-cmd-goals += $(foreach g, $(MAKECMDGOALS), $(.ninja-goals.$g)) makefile-targets := build.ninja ctags TAGS cscope dist clean uninstall # "ninja -t targets" also lists all prerequisites. If build system
Because of two stray parentheses at the end of the definition of ninja-cmd-goals, the test that is last in the .check-TESTSUITENAME.deps variable will not be rebuilt. Fix that. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)