diff mbox series

ppc: Remove redundant macro MSR_BOOK3S_MASK.

Message ID 20220728201135.223-1-luoyonggang@gmail.com
State New
Headers show
Series ppc: Remove redundant macro MSR_BOOK3S_MASK. | expand

Commit Message

Yonggang Luo July 28, 2022, 8:11 p.m. UTC 
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
 target/ppc/excp_helper.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Daniel Henrique Barboza July 28, 2022, 9:39 p.m. UTC | #1 
On 7/28/22 17:11, Yonggang Luo wrote:
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>   target/ppc/excp_helper.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index cb752b184a..7550aafed6 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2015,7 +2015,6 @@ void helper_rfi(CPUPPCState *env)
>       do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
>   }
>   
> -#define MSR_BOOK3S_MASK

The tag was introduced by a2e71b28e832 ("ppc: Fix rfi/rfid/hrfi/... emulation").
Even back then it wasn't being used.


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


Laurent, I believe this is qemu-trivial material. Let me know if you want
me to get it via the ppc tree instead.


Daniel


>   #if defined(TARGET_PPC64)
>   void helper_rfid(CPUPPCState *env)
>   {
Laurent Vivier Aug. 4, 2022, 11:48 a.m. UTC | #2 
Le 28/07/2022 à 22:11, Yonggang Luo a écrit :
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>   target/ppc/excp_helper.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index cb752b184a..7550aafed6 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -2015,7 +2015,6 @@ void helper_rfi(CPUPPCState *env)
>       do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
>   }
>   
> -#define MSR_BOOK3S_MASK
>   #if defined(TARGET_PPC64)
>   void helper_rfid(CPUPPCState *env)
>   {

Applied to my trivial-patches branch.

Thanks,
Laurent
diff mbox series

Patch

diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index cb752b184a..7550aafed6 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -2015,7 +2015,6 @@  void helper_rfi(CPUPPCState *env)
     do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
 }
 
-#define MSR_BOOK3S_MASK
 #if defined(TARGET_PPC64)
 void helper_rfid(CPUPPCState *env)
 {