diff mbox series

[3/3] tests/unit/test-qga: Replace the word 'blacklist' in the guest agent unit test

Message ID 20220727092135.302915-4-thuth@redhat.com
State New
Headers show
Series Replace 'blacklist' and 'whitelist' in the guest agent | expand

Commit Message

Thomas Huth July 27, 2022, 9:21 a.m. UTC
Let's use better, more inclusive wording here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/unit/test-qga.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Konstantin Kostiuk July 27, 2022, 9:31 a.m. UTC | #1
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>

On Wed, Jul 27, 2022 at 12:21 PM Thomas Huth <thuth@redhat.com> wrote:

> Let's use better, more inclusive wording here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/unit/test-qga.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
> index c398866f46..80bb6b0866 100644
> --- a/tests/unit/test-qga.c
> +++ b/tests/unit/test-qga.c
> @@ -629,7 +629,7 @@ static void test_qga_get_time(gconstpointer fix)
>      g_assert_cmpint(time, >, 0);
>  }
>
> -static void test_qga_blacklist(gconstpointer data)
> +static void test_qga_blockedrpcs(gconstpointer data)
>  {
>      TestFixture fix;
>      QDict *ret, *error;
> @@ -637,7 +637,7 @@ static void test_qga_blacklist(gconstpointer data)
>
>      fixture_setup(&fix, "-b guest-ping,guest-get-time", NULL);
>
> -    /* check blacklist */
> +    /* check blocked RPCs */
>      ret = qmp_fd(fix.fd, "{'execute': 'guest-ping'}");
>      g_assert_nonnull(ret);
>      error = qdict_get_qdict(ret, "error");
> @@ -968,7 +968,7 @@ int main(int argc, char **argv)
>      g_test_add_data_func("/qga/fsfreeze-status", &fix,
>                           test_qga_fsfreeze_status);
>
> -    g_test_add_data_func("/qga/blacklist", NULL, test_qga_blacklist);
> +    g_test_add_data_func("/qga/blockedrpcs", NULL, test_qga_blockedrpcs);
>      g_test_add_data_func("/qga/config", NULL, test_qga_config);
>      g_test_add_data_func("/qga/guest-exec", &fix, test_qga_guest_exec);
>      g_test_add_data_func("/qga/guest-exec-invalid", &fix,
> --
> 2.31.1
>
>
Daniel P. Berrangé July 27, 2022, 9:34 a.m. UTC | #2
On Wed, Jul 27, 2022 at 11:21:35AM +0200, Thomas Huth wrote:
> Let's use better, more inclusive wording here.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/unit/test-qga.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
diff mbox series

Patch

diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
index c398866f46..80bb6b0866 100644
--- a/tests/unit/test-qga.c
+++ b/tests/unit/test-qga.c
@@ -629,7 +629,7 @@  static void test_qga_get_time(gconstpointer fix)
     g_assert_cmpint(time, >, 0);
 }
 
-static void test_qga_blacklist(gconstpointer data)
+static void test_qga_blockedrpcs(gconstpointer data)
 {
     TestFixture fix;
     QDict *ret, *error;
@@ -637,7 +637,7 @@  static void test_qga_blacklist(gconstpointer data)
 
     fixture_setup(&fix, "-b guest-ping,guest-get-time", NULL);
 
-    /* check blacklist */
+    /* check blocked RPCs */
     ret = qmp_fd(fix.fd, "{'execute': 'guest-ping'}");
     g_assert_nonnull(ret);
     error = qdict_get_qdict(ret, "error");
@@ -968,7 +968,7 @@  int main(int argc, char **argv)
     g_test_add_data_func("/qga/fsfreeze-status", &fix,
                          test_qga_fsfreeze_status);
 
-    g_test_add_data_func("/qga/blacklist", NULL, test_qga_blacklist);
+    g_test_add_data_func("/qga/blockedrpcs", NULL, test_qga_blockedrpcs);
     g_test_add_data_func("/qga/config", NULL, test_qga_config);
     g_test_add_data_func("/qga/guest-exec", &fix, test_qga_guest_exec);
     g_test_add_data_func("/qga/guest-exec-invalid", &fix,