diff mbox series

Hexagon (tests/tcg/hexagon) add compiler options to EXTRA_CFLAGS

Message ID 20220726191757.30104-1-tsimpson@quicinc.com
State New
Headers show
Series Hexagon (tests/tcg/hexagon) add compiler options to EXTRA_CFLAGS | expand

Commit Message

Taylor Simpson July 26, 2022, 7:17 p.m. UTC
The cross_cc_cflags_hexagon in configure are not getting passed to
the Hexagon cross compiler.  Set EXTRA_CFLAGS in
tests/tcg/hexagon/Makefile.target.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
---
 tests/tcg/hexagon/Makefile.target | 1 +
 1 file changed, 1 insertion(+)

Comments

Richard Henderson July 28, 2022, 8:24 p.m. UTC | #1
On 7/26/22 12:17, Taylor Simpson wrote:
> The cross_cc_cflags_hexagon in configure are not getting passed to
> the Hexagon cross compiler.  Set EXTRA_CFLAGS in
> tests/tcg/hexagon/Makefile.target.
> 
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
>   tests/tcg/hexagon/Makefile.target | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

> 
> diff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile.target
> index 23b9870534..627bf58fe6 100644
> --- a/tests/tcg/hexagon/Makefile.target
> +++ b/tests/tcg/hexagon/Makefile.target
> @@ -20,6 +20,7 @@ EXTRA_RUNS =
>   
>   CFLAGS += -Wno-incompatible-pointer-types -Wno-undefined-internal
>   CFLAGS += -fno-unroll-loops
> +EXTRA_CFLAGS += -mv67 -O2
>   
>   HEX_SRC=$(SRC_PATH)/tests/tcg/hexagon
>   VPATH += $(HEX_SRC)
Paolo Bonzini July 28, 2022, 10:19 p.m. UTC | #2
On 7/26/22 21:17, Taylor Simpson wrote:
> The cross_cc_cflags_hexagon in configure are not getting passed to
> the Hexagon cross compiler.  Set EXTRA_CFLAGS in
> tests/tcg/hexagon/Makefile.target.
> 
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---

The bug applies to all targets, I am going to post a patch to fix it.

Paolo
diff mbox series

Patch

diff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile.target
index 23b9870534..627bf58fe6 100644
--- a/tests/tcg/hexagon/Makefile.target
+++ b/tests/tcg/hexagon/Makefile.target
@@ -20,6 +20,7 @@  EXTRA_RUNS =
 
 CFLAGS += -Wno-incompatible-pointer-types -Wno-undefined-internal
 CFLAGS += -fno-unroll-loops
+EXTRA_CFLAGS += -mv67 -O2
 
 HEX_SRC=$(SRC_PATH)/tests/tcg/hexagon
 VPATH += $(HEX_SRC)