| Message ID | 20220421142435.569600-1-hreitz@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | iotests/108: Fix when missing user_allow_other | expand |
Hanna Reitz <hreitz@redhat.com> writes: > FUSE exports' allow-other option defaults to "auto", which means that it > will try passing allow_other as a mount option, and fall back to not > using it when an error occurs. We make no effort to hide fusermount's > error message (because it would be difficult, and because users might > want to know about the fallback occurring), and so when allow_other does > not work (primarily when /etc/fuse.conf does not contain > user_allow_other), this error message will appear and break the > reference output. > > We do not need allow_other here, though, so we can just pass > allow-other=off to fix that. > > Reported-by: Markus Armbruster <armbru@redhat.com> > Signed-off-by: Hanna Reitz <hreitz@redhat.com> Tested-by: Markus Armbruster <armbru@redhat.com> Thanks!
On Thu, Apr 21, 2022 at 04:24:35PM +0200, Hanna Reitz wrote: > FUSE exports' allow-other option defaults to "auto", which means that it > will try passing allow_other as a mount option, and fall back to not > using it when an error occurs. We make no effort to hide fusermount's > error message (because it would be difficult, and because users might > want to know about the fallback occurring), and so when allow_other does > not work (primarily when /etc/fuse.conf does not contain > user_allow_other), this error message will appear and break the > reference output. > > We do not need allow_other here, though, so we can just pass > allow-other=off to fix that. > > Reported-by: Markus Armbruster <armbru@redhat.com> > Signed-off-by: Hanna Reitz <hreitz@redhat.com> > --- > tests/qemu-iotests/108 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I hit this today as well, and your fix works. Tested-by: Eric Blake <eblake@redhat.com>
diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108 index 688d3ae8f6..9e923d6a59 100755 --- a/tests/qemu-iotests/108 +++ b/tests/qemu-iotests/108 @@ -326,7 +326,7 @@ else $QSD \ --blockdev file,node-name=export-node,filename="$TEST_IMG" \ - --export fuse,id=fuse-export,node-name=export-node,mountpoint="$export_mp",writable=on,growable=off \ + --export fuse,id=fuse-export,node-name=export-node,mountpoint="$export_mp",writable=on,growable=off,allow-other=off \ --pidfile "$TEST_DIR/qsd.pid" \ --daemonize fi
FUSE exports' allow-other option defaults to "auto", which means that it will try passing allow_other as a mount option, and fall back to not using it when an error occurs. We make no effort to hide fusermount's error message (because it would be difficult, and because users might want to know about the fallback occurring), and so when allow_other does not work (primarily when /etc/fuse.conf does not contain user_allow_other), this error message will appear and break the reference output. We do not need allow_other here, though, so we can just pass allow-other=off to fix that. Reported-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Hanna Reitz <hreitz@redhat.com> --- tests/qemu-iotests/108 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)