Message ID | 20220421133549.2876244-1-marcandre.lureau@redhat.com |
---|---|
State | New |
Headers | show |
Series | qga: use fixed-length and GDateTime for log timestamp | expand |
On Thu, Apr 21, 2022 at 05:35:49PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > The old code is kind of wrong. Say it's 1649309843.000001 seconds past > the epoch. Prints "1649309843.1". 9us later, it prints "1649309843.10". > Should really use %06lu for the microseconds part. > > Use GDateTime instead, as suggested by Daniel. > > Suggested-by: Markus Armbruster <armbru@redhat.com> > Suggested-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > qga/main.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
diff --git a/qga/main.c b/qga/main.c index 3c20bf1fbfe0..3b9546c18584 100644 --- a/qga/main.c +++ b/qga/main.c @@ -328,11 +328,9 @@ static void ga_log(const gchar *domain, GLogLevelFlags level, #else if (level & s->log_level) { #endif - gint64 t = g_get_real_time(); - fprintf(s->log_file, - "%" G_GINT64_FORMAT ".%" G_GINT64_FORMAT - ": %s: %s\n", t / G_USEC_PER_SEC, t % G_USEC_PER_SEC, - level_str, msg); + g_autoptr(GDateTime) now = g_date_time_new_now_utc(); + g_autofree char *nowstr = g_date_time_format(now, "%s.%f"); + fprintf(s->log_file, "%s: %s: %s\n", nowstr, level_str, msg); fflush(s->log_file); } }