Message ID | 20220417045937.2128699-1-i@yvt.jp |
---|---|
State | New |
Headers | show |
Series | target/rx: set PSW.I when executing wait instruction | expand |
On 4/16/22 21:59, Tomoaki Kawada wrote: > This patch fixes the implementation of the wait instruction to > implicitly update PSW.I as required by the ISA specification. > > Signed-off-by: Tomoaki Kawada <i@yvt.jp> > --- > target/rx/op_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c > index 11f952d340..81645adde3 100644 > --- a/target/rx/op_helper.c > +++ b/target/rx/op_helper.c > @@ -448,6 +448,7 @@ void QEMU_NORETURN helper_wait(CPURXState *env) > > cs->halted = 1; > env->in_sleep = 1; > + env->psw_i = 1; > raise_exception(env, EXCP_HLT, 0); > } > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Sun, 17 Apr 2022 13:59:38 +0900, Tomoaki Kawada wrote: > > This patch fixes the implementation of the wait instruction to > implicitly update PSW.I as required by the ISA specification. > > Signed-off-by: Tomoaki Kawada <i@yvt.jp> > --- > target/rx/op_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c > index 11f952d340..81645adde3 100644 > --- a/target/rx/op_helper.c > +++ b/target/rx/op_helper.c > @@ -448,6 +448,7 @@ void QEMU_NORETURN helper_wait(CPURXState *env) > > cs->halted = 1; > env->in_sleep = 1; > + env->psw_i = 1; > raise_exception(env, EXCP_HLT, 0); > } > > -- > 2.35.1 > Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
On 4/16/22 21:59, Tomoaki Kawada wrote: > This patch fixes the implementation of the wait instruction to > implicitly update PSW.I as required by the ISA specification. > > Signed-off-by: Tomoaki Kawada <i@yvt.jp> > --- > target/rx/op_helper.c | 1 + > 1 file changed, 1 insertion(+) Queued to target-rx-next. r~
diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c index 11f952d340..81645adde3 100644 --- a/target/rx/op_helper.c +++ b/target/rx/op_helper.c @@ -448,6 +448,7 @@ void QEMU_NORETURN helper_wait(CPURXState *env) cs->halted = 1; env->in_sleep = 1; + env->psw_i = 1; raise_exception(env, EXCP_HLT, 0); }
This patch fixes the implementation of the wait instruction to implicitly update PSW.I as required by the ISA specification. Signed-off-by: Tomoaki Kawada <i@yvt.jp> --- target/rx/op_helper.c | 1 + 1 file changed, 1 insertion(+)