| Message ID | 20220415131900.793161-4-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | block: fix coroutine_fn annotations | expand |
On Fri, Apr 15, 2022 at 03:18:37PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > include/block/nbd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/block/nbd.h b/include/block/nbd.h > index a98eb665da..5c3710fa52 100644 > --- a/include/block/nbd.h > +++ b/include/block/nbd.h > @@ -423,6 +423,6 @@ QIOChannel *coroutine_fn > nbd_co_establish_connection(NBDClientConnection *conn, NBDExportInfo *info, > bool blocking, Error **errp); > > -void coroutine_fn nbd_co_establish_connection_cancel(NBDClientConnection *conn); > +void nbd_co_establish_connection_cancel(NBDClientConnection *conn); Should we rename this function to drop _co_ while at it?
On 4/19/22 20:08, Eric Blake wrote: >> >> -void coroutine_fn nbd_co_establish_connection_cancel(NBDClientConnection *conn); >> +void nbd_co_establish_connection_cancel(NBDClientConnection *conn); > Should we rename this function to drop_co_ while at it? Or perhaps rename it to nbd_cancel_co_establish_connection... Paolo
diff --git a/include/block/nbd.h b/include/block/nbd.h index a98eb665da..5c3710fa52 100644 --- a/include/block/nbd.h +++ b/include/block/nbd.h @@ -423,6 +423,6 @@ QIOChannel *coroutine_fn nbd_co_establish_connection(NBDClientConnection *conn, NBDExportInfo *info, bool blocking, Error **errp); -void coroutine_fn nbd_co_establish_connection_cancel(NBDClientConnection *conn); +void nbd_co_establish_connection_cancel(NBDClientConnection *conn); #endif
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- include/block/nbd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)