| Message ID | 20220413042054.1484640-1-liuyd.fnst@fujitsu.com |
|---|---|
| State | New |
| Headers | show |
| Series | docs: Correct the default thread-pool-size | expand |
[+cc vgoyal@redhat.com] On 4/13/22 12:20 PM, Liu Yiding wrote: > Refer to 26ec190964 virtiofsd: Do not use a thread pool by default > > Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> > --- > docs/tools/virtiofsd.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst > index 0c0560203c..33fed08c6f 100644 > --- a/docs/tools/virtiofsd.rst > +++ b/docs/tools/virtiofsd.rst > @@ -127,7 +127,7 @@ Options > .. option:: --thread-pool-size=NUM > > Restrict the number of worker threads per request queue to NUM. The default > - is 64. > + is 0. > > .. option:: --cache=none|auto|always >
[+cc dgilbert@redhat.com stefanha@redhat.com] On 4/14/22 1:05 PM, liuyd.fnst@fujitsu.com wrote: > [+cc vgoyal@redhat.com] > > On 4/13/22 12:20 PM, Liu Yiding wrote: >> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default >> >> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> >> --- >> docs/tools/virtiofsd.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst >> index 0c0560203c..33fed08c6f 100644 >> --- a/docs/tools/virtiofsd.rst >> +++ b/docs/tools/virtiofsd.rst >> @@ -127,7 +127,7 @@ Options >> .. option:: --thread-pool-size=NUM >> >> Restrict the number of worker threads per request queue to NUM. The default >> - is 64. >> + is 0. >> >> .. option:: --cache=none|auto|always >>
On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote: > Refer to 26ec190964 virtiofsd: Do not use a thread pool by default > > Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> Looks good. Our default used to be --thread-pool-size=64. But we changed it to using no thread pool because on lower end of workloads it performed better. When multiple threads are doing parallel I/O then, thread pool helps. So people who want to do lots of parallel I/O should manually enable thread pool. Acked-by: Vivek Goyal <vgoyal@redhat.com> Vivek > --- > docs/tools/virtiofsd.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst > index 0c0560203c..33fed08c6f 100644 > --- a/docs/tools/virtiofsd.rst > +++ b/docs/tools/virtiofsd.rst > @@ -127,7 +127,7 @@ Options > .. option:: --thread-pool-size=NUM > > Restrict the number of worker threads per request queue to NUM. The default > - is 64. > + is 0. > > .. option:: --cache=none|auto|always > > -- > 2.31.1 > > > >
Hi, Stefan Please help review it. I'm sorry that I forgot to add you to the recipient 😅 On 4/14/22 8:19 PM, Vivek Goyal wrote: > On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote: >> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default >> >> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> > Looks good. Our default used to be --thread-pool-size=64. But we changed > it to using no thread pool because on lower end of workloads it performed > better. When multiple threads are doing parallel I/O then, thread pool > helps. So people who want to do lots of parallel I/O should manually > enable thread pool. > > Acked-by: Vivek Goyal <vgoyal@redhat.com> > > Vivek >> --- >> docs/tools/virtiofsd.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst >> index 0c0560203c..33fed08c6f 100644 >> --- a/docs/tools/virtiofsd.rst >> +++ b/docs/tools/virtiofsd.rst >> @@ -127,7 +127,7 @@ Options >> .. option:: --thread-pool-size=NUM >> >> Restrict the number of worker threads per request queue to NUM. The default >> - is 64. >> + is 0. >> >> .. option:: --cache=none|auto|always >> >> -- >> 2.31.1 >> >> >> >>
[+cc qemu-trivial] On 4/14/22 8:19 PM, Vivek Goyal wrote: > On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote: >> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default >> >> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> > Looks good. Our default used to be --thread-pool-size=64. But we changed > it to using no thread pool because on lower end of workloads it performed > better. When multiple threads are doing parallel I/O then, thread pool > helps. So people who want to do lots of parallel I/O should manually > enable thread pool. > > Acked-by: Vivek Goyal <vgoyal@redhat.com> > > Vivek >> --- >> docs/tools/virtiofsd.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst >> index 0c0560203c..33fed08c6f 100644 >> --- a/docs/tools/virtiofsd.rst >> +++ b/docs/tools/virtiofsd.rst >> @@ -127,7 +127,7 @@ Options >> .. option:: --thread-pool-size=NUM >> >> Restrict the number of worker threads per request queue to NUM. The default >> - is 64. >> + is 0. >> >> .. option:: --cache=none|auto|always >> >> -- >> 2.31.1 >> >> >> >>
Gently ping On 4/27/22 9:12 AM, liuyd.fnst@fujitsu.com wrote: > [+cc qemu-trivial] > > On 4/14/22 8:19 PM, Vivek Goyal wrote: >> On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote: >>> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default >>> >>> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> >> Looks good. Our default used to be --thread-pool-size=64. But we changed >> it to using no thread pool because on lower end of workloads it performed >> better. When multiple threads are doing parallel I/O then, thread pool >> helps. So people who want to do lots of parallel I/O should manually >> enable thread pool. >> >> Acked-by: Vivek Goyal <vgoyal@redhat.com> >> >> Vivek >>> --- >>> docs/tools/virtiofsd.rst | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst >>> index 0c0560203c..33fed08c6f 100644 >>> --- a/docs/tools/virtiofsd.rst >>> +++ b/docs/tools/virtiofsd.rst >>> @@ -127,7 +127,7 @@ Options >>> .. option:: --thread-pool-size=NUM >>> >>> Restrict the number of worker threads per request queue to NUM. The default >>> - is 64. >>> + is 0. >>> >>> .. option:: --cache=none|auto|always >>> >>> -- >>> 2.31.1 >>> >>> >>> >>>
On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote: > Refer to 26ec190964 virtiofsd: Do not use a thread pool by default > > Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> > --- > docs/tools/virtiofsd.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi, Sorry it took so long to apply this! Thanks, applied to my block-next tree: https://gitlab.com/stefanha/qemu/commits/block-next Stefan
diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst index 0c0560203c..33fed08c6f 100644 --- a/docs/tools/virtiofsd.rst +++ b/docs/tools/virtiofsd.rst @@ -127,7 +127,7 @@ Options .. option:: --thread-pool-size=NUM Restrict the number of worker threads per request queue to NUM. The default - is 64. + is 0. .. option:: --cache=none|auto|always
Refer to 26ec190964 virtiofsd: Do not use a thread pool by default Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> --- docs/tools/virtiofsd.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)