diff mbox series

[14/27] scripts/modinfo-collect: remove unused/dead code

Message ID 20220316095344.2613706-1-marcandre.lureau@redhat.com
State New
Headers show
Series Misc fixes and cleanups for 7.0? | expand

Commit Message

Marc-André Lureau March 16, 2022, 9:53 a.m. UTC 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 scripts/modinfo-collect.py | 5 -----
 1 file changed, 5 deletions(-)

Comments

Marc-André Lureau March 16, 2022, 2:57 p.m. UTC | #1 
---------- Forwarded message ---------
From: Hoffmann, Gerd <kraxel@redhat.com>
Date: Wed, Mar 16, 2022 at 6:54 PM
Subject: Re: Fwd: [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code
To: Marc-André Lureau <marcandre.lureau@redhat.com>


On Wed, Mar 16, 2022 at 06:33:03PM +0400, Marc-André Lureau wrote:
> Hi Gerd, can you ack?
>
> (get_maintainer.pl doesn't catch you here)

Looks ok, arg is never set to True.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

>
> thanks
>
> ---------- Forwarded message ---------
> From: <marcandre.lureau@redhat.com>
> Date: Wed, Mar 16, 2022 at 1:53 PM
> Subject: [PATCH 14/27] scripts/modinfo-collect: remove unused/dead code
> To: <qemu-devel@nongnu.org>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>, John Snow
> <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>
>
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  scripts/modinfo-collect.py | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py
> index 61b90688c6dc..4e7584df6676 100755
> --- a/scripts/modinfo-collect.py
> +++ b/scripts/modinfo-collect.py
> @@ -18,13 +18,8 @@ def find_command(src, target, compile_commands):
>
>  def process_command(src, command):
>      skip = False
> -    arg = False
>      out = []
>      for item in shlex.split(command):
> -        if arg:
> -            out.append(x)
> -            arg = False
> -            continue
>          if skip:
>              skip = False
>              continue
> --
> 2.35.1.273.ge6ebfd0e8cbb
>

--
John Snow March 16, 2022, 8:02 p.m. UTC | #2 
On Wed, Mar 16, 2022, 5:53 AM <marcandre.lureau@redhat.com> wrote:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  scripts/modinfo-collect.py | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py
> index 61b90688c6dc..4e7584df6676 100755
> --- a/scripts/modinfo-collect.py
> +++ b/scripts/modinfo-collect.py
> @@ -18,13 +18,8 @@ def find_command(src, target, compile_commands):
>
>  def process_command(src, command):
>      skip = False
> -    arg = False
>      out = []
>      for item in shlex.split(command):
> -        if arg:
> -            out.append(x)
> -            arg = False
> -            continue
>          if skip:
>              skip = False
>              continue
> --
> 2.35.1.273.ge6ebfd0e8cbb
>

Acked-By <jsnow@redhat.com>
diff mbox series

Patch

diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py
index 61b90688c6dc..4e7584df6676 100755
--- a/scripts/modinfo-collect.py
+++ b/scripts/modinfo-collect.py
@@ -18,13 +18,8 @@  def find_command(src, target, compile_commands):
 
 def process_command(src, command):
     skip = False
-    arg = False
     out = []
     for item in shlex.split(command):
-        if arg:
-            out.append(x)
-            arg = False
-            continue
         if skip:
             skip = False
             continue