| Message ID | 20220316095226.2613545-1-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Misc fixes and cleanups for 7.0? | expand |
Hi On Wed, Mar 16, 2022 at 1:52 PM <marcandre.lureau@redhat.com> wrote: > > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > chardev subsystem/library doesn't use gnutls. Use the dedicated > chardev_ss.dependencies() instead. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 784e91753630..f20712cb93d7 100644 > --- a/meson.build > +++ b/meson.build > @@ -3035,7 +3035,7 @@ qmp = declare_dependency(link_whole: [libqmp]) > > libchardev = static_library('chardev', chardev_ss.sources() + genh, > name_suffix: 'fa', > - dependencies: [gnutls], > + dependencies: chardev_ss.dependencies(), Looking at history, it was added in commit 3eacf70bb5a83e ("meson: Propagate gnutls dependency") because crypto/tlscreds.h included GnuTLS. This was cleaned-up later by commit 678bcc3c2cf222 ("crypto: Make QCryptoTLSCreds* structures private"). Please ack > build_by_default: false) > > chardev = declare_dependency(link_whole: libchardev) > -- > 2.35.1.273.ge6ebfd0e8cbb >
diff --git a/meson.build b/meson.build index 784e91753630..f20712cb93d7 100644 --- a/meson.build +++ b/meson.build @@ -3035,7 +3035,7 @@ qmp = declare_dependency(link_whole: [libqmp]) libchardev = static_library('chardev', chardev_ss.sources() + genh, name_suffix: 'fa', - dependencies: [gnutls], + dependencies: chardev_ss.dependencies(), build_by_default: false) chardev = declare_dependency(link_whole: libchardev)