| Message ID | 20220315144107.1012530-1-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Don't include sysemu/tcg.h if it is not necessary | expand |
Thomas Huth <thuth@redhat.com> writes: > This header only defines the tcg_allowed variable and the tcg_enabled() > function - which are not required in many files that include this > header. Drop the #include statement there. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com>
On 3/15/22 07:41, Thomas Huth wrote: > This header only defines the tcg_allowed variable and the tcg_enabled() > function - which are not required in many files that include this > header. Drop the #include statement there. > > Signed-off-by: Thomas Huth<thuth@redhat.com> > --- > accel/tcg/hmp.c | 1 - > accel/tcg/tcg-accel-ops-icount.c | 1 - > bsd-user/main.c | 1 - > hw/virtio/vhost.c | 1 - > linux-user/main.c | 1 - > monitor/misc.c | 1 - > target/arm/helper.c | 1 - > target/s390x/cpu_models_sysemu.c | 1 - > target/s390x/helper.c | 1 - > 9 files changed, 9 deletions(-) Thanks. Queued to tcg-next. r~
diff --git a/accel/tcg/hmp.c b/accel/tcg/hmp.c index d2ea352655..bb67941420 100644 --- a/accel/tcg/hmp.c +++ b/accel/tcg/hmp.c @@ -4,7 +4,6 @@ #include "qapi/qapi-commands-machine.h" #include "exec/exec-all.h" #include "monitor/monitor.h" -#include "sysemu/tcg.h" static void hmp_tcg_register(void) { diff --git a/accel/tcg/tcg-accel-ops-icount.c b/accel/tcg/tcg-accel-ops-icount.c index bdaf2c943b..8827e1d2cc 100644 --- a/accel/tcg/tcg-accel-ops-icount.c +++ b/accel/tcg/tcg-accel-ops-icount.c @@ -25,7 +25,6 @@ #include "qemu/osdep.h" #include "qemu-common.h" -#include "sysemu/tcg.h" #include "sysemu/replay.h" #include "sysemu/cpu-timers.h" #include "qemu/main-loop.h" diff --git a/bsd-user/main.c b/bsd-user/main.c index 88d347d05e..e274dd92d7 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -27,7 +27,6 @@ #include "qemu-common.h" #include "qemu/units.h" #include "qemu/accel.h" -#include "sysemu/tcg.h" #include "qemu-version.h" #include <machine/trap.h> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index b643f42ea4..c9bf01a424 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -26,7 +26,6 @@ #include "migration/blocker.h" #include "migration/qemu-file-types.h" #include "sysemu/dma.h" -#include "sysemu/tcg.h" #include "trace.h" /* enabled until disconnected backend stabilizes */ diff --git a/linux-user/main.c b/linux-user/main.c index fbc9bcfd5f..f1711b82ec 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -21,7 +21,6 @@ #include "qemu-common.h" #include "qemu/units.h" #include "qemu/accel.h" -#include "sysemu/tcg.h" #include "qemu-version.h" #include <sys/syscall.h> #include <sys/resource.h> diff --git a/monitor/misc.c b/monitor/misc.c index b1839cb8ee..b5ca141e1d 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -48,7 +48,6 @@ #include "qapi/util.h" #include "sysemu/blockdev.h" #include "sysemu/sysemu.h" -#include "sysemu/tcg.h" #include "sysemu/tpm.h" #include "qapi/qmp/qdict.h" #include "qapi/qmp/qerror.h" diff --git a/target/arm/helper.c b/target/arm/helper.c index 088956eecf..94221a3e8d 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -27,7 +27,6 @@ #include "sysemu/cpus.h" #include "sysemu/cpu-timers.h" #include "sysemu/kvm.h" -#include "sysemu/tcg.h" #include "qemu/range.h" #include "qapi/qapi-commands-machine-target.h" #include "qapi/error.h" diff --git a/target/s390x/cpu_models_sysemu.c b/target/s390x/cpu_models_sysemu.c index 05c3ccaaff..d8a141a023 100644 --- a/target/s390x/cpu_models_sysemu.c +++ b/target/s390x/cpu_models_sysemu.c @@ -15,7 +15,6 @@ #include "s390x-internal.h" #include "kvm/kvm_s390x.h" #include "sysemu/kvm.h" -#include "sysemu/tcg.h" #include "qapi/error.h" #include "qapi/visitor.h" #include "qapi/qmp/qerror.h" diff --git a/target/s390x/helper.c b/target/s390x/helper.c index 6e35473c7f..473c8e51b0 100644 --- a/target/s390x/helper.c +++ b/target/s390x/helper.c @@ -27,7 +27,6 @@ #include "hw/s390x/pv.h" #include "sysemu/hw_accel.h" #include "sysemu/runstate.h" -#include "sysemu/tcg.h" void s390x_tod_timer(void *opaque) {
This header only defines the tcg_allowed variable and the tcg_enabled() function - which are not required in many files that include this header. Drop the #include statement there. Signed-off-by: Thomas Huth <thuth@redhat.com> --- accel/tcg/hmp.c | 1 - accel/tcg/tcg-accel-ops-icount.c | 1 - bsd-user/main.c | 1 - hw/virtio/vhost.c | 1 - linux-user/main.c | 1 - monitor/misc.c | 1 - target/arm/helper.c | 1 - target/s390x/cpu_models_sysemu.c | 1 - target/s390x/helper.c | 1 - 9 files changed, 9 deletions(-)