| Message ID | 20220306123410.61063-1-akihiko.odaki@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] coreaudio: Always return 0 in handle_voice_change | expand |
On 6/3/22 13:34, Akihiko Odaki wrote: > handle_voice_change() is a CoreAudio callback function as of CoreAudio type > AudioObjectPropertyListenerProc, and for the latter MacOSX.sdk/System/ > Library/Frameworks/CoreAudio.framework/Headers/AudioHardware.h > says "The return value is currently unused and should always be 0.". > > Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com> > --- > audio/coreaudio.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff --git a/audio/coreaudio.c b/audio/coreaudio.c index 0f19d0ce01c..91445096358 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -540,7 +540,6 @@ static OSStatus handle_voice_change( const AudioObjectPropertyAddress *in_addresses, void *in_client_data) { - OSStatus status; coreaudioVoiceOut *core = in_client_data; qemu_mutex_lock_iothread(); @@ -549,13 +548,12 @@ static OSStatus handle_voice_change( fini_out_device(core); } - status = init_out_device(core); - if (!status) { + if (!init_out_device(core)) { update_device_playback_state(core); } qemu_mutex_unlock_iothread(); - return status; + return 0; } static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,
handle_voice_change() is a CoreAudio callback function as of CoreAudio type AudioObjectPropertyListenerProc, and for the latter MacOSX.sdk/System/ Library/Frameworks/CoreAudio.framework/Headers/AudioHardware.h says "The return value is currently unused and should always be 0.". Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com> --- audio/coreaudio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)