| Message ID | 20220225205948.3693480-6-jsnow@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Python: Fix qmp race condition on accept() | expand |
On Fri, Feb 25, 2022 at 03:59:43PM -0500, John Snow wrote: > I would really like to keep this under 1000 lines, I promise. Doesn't > look like it's gonna happen. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > python/qemu/aqmp/protocol.py | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> > > diff --git a/python/qemu/aqmp/protocol.py b/python/qemu/aqmp/protocol.py > index 56f05b9030..631bcdaa55 100644 > --- a/python/qemu/aqmp/protocol.py > +++ b/python/qemu/aqmp/protocol.py > @@ -10,6 +10,9 @@ > class. > """ > > +# It's all the docstrings ... ! It's long for a good reason ^_^; > +# pylint: disable=too-many-lines Indeed that is a crazy check if it can't be made to only consider non-comment lines in its metric. Regards, Daniel
diff --git a/python/qemu/aqmp/protocol.py b/python/qemu/aqmp/protocol.py index 56f05b9030..631bcdaa55 100644 --- a/python/qemu/aqmp/protocol.py +++ b/python/qemu/aqmp/protocol.py @@ -10,6 +10,9 @@ class. """ +# It's all the docstrings ... ! It's long for a good reason ^_^; +# pylint: disable=too-many-lines + import asyncio from asyncio import StreamReader, StreamWriter from enum import Enum
I would really like to keep this under 1000 lines, I promise. Doesn't look like it's gonna happen. Signed-off-by: John Snow <jsnow@redhat.com> --- python/qemu/aqmp/protocol.py | 3 +++ 1 file changed, 3 insertions(+)