| Message ID | 20220105212338.49899-15-danielhb413@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | user creatable pnv-phb3/pnv-phb4 devices | expand |
On 1/5/22 22:23, Daniel Henrique Barboza wrote: > At this moment, stack->phb is the plain PnvPHB4 device itself instead > of a pointer to the device. This will present a problem when adding user > creatable devices because we can't deal with this struct and the > realize() callback from the user creatable device. > > We can't get rid of this attribute, similar to what we did when enabling > pnv-phb3 user creatable devices, because pnv_phb4_update_regions() needs > to access stack->phb to do its job. This function is called twice in > pnv_pec_stk_update_map(), which is one of the nested xscom write > callbacks (via pnv_pec_stk_nest_xscom_write()). In fact, > pnv_pec_stk_update_map() code comment is explicit about how the order of > the unmap/map operations relates with the PHB subregions. > > All of this indicates that this code is tied together in a way that we > either go on a crusade, featuring lots of refactories and redesign and > considerable pain, to decouple stack and phb mapping, or we allow stack > update_map operations to access the associated PHB as it is today even > after introducing pnv-phb4 user devices.> > This patch chooses the latter. Instead of getting rid of stack->phb, > turn it into a PHB pointer. This will allow us to assign an user created > PHB to an existing stack later. > > Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> > --- > hw/pci-host/pnv_phb4.c | 2 +- > hw/pci-host/pnv_phb4_pec.c | 2 +- > include/hw/pci-host/pnv_phb4.h | 7 +++++-- > 3 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c > index 4c785bbe4c..9e670e41d2 100644 > --- a/hw/pci-host/pnv_phb4.c > +++ b/hw/pci-host/pnv_phb4.c > @@ -1449,7 +1449,7 @@ type_init(pnv_phb4_register_types); > > void pnv_phb4_update_regions(PnvPhb4PecStack *stack) > { > - PnvPHB4 *phb = &stack->phb; > + PnvPHB4 *phb = stack->phb; > > /* Unmap first always */ > if (memory_region_is_mapped(&phb->mr_regs)) { > diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host/pnv_phb4_pec.c > index 0675fc55bc..be6eefdbb1 100644 > --- a/hw/pci-host/pnv_phb4_pec.c > +++ b/hw/pci-host/pnv_phb4_pec.c > @@ -563,7 +563,7 @@ static void pnv_pec_stk_realize(DeviceState *dev, Error **errp) > PHB4_PEC_PCI_STK_REGS_COUNT); > > /* PHB pass-through */ > - pnv_phb4_set_stack_phb_props(stack, &stack->phb); > + pnv_phb4_set_stack_phb_props(stack, stack->phb); > if (!sysbus_realize(SYS_BUS_DEVICE(&stack->phb), errp)) { Shouldn't that be stack->phb ? What about the object_initialize_child() ? C. > return; > } > diff --git a/include/hw/pci-host/pnv_phb4.h b/include/hw/pci-host/pnv_phb4.h > index b2c4a6b263..2fb5e119c4 100644 > --- a/include/hw/pci-host/pnv_phb4.h > +++ b/include/hw/pci-host/pnv_phb4.h > @@ -178,8 +178,11 @@ struct PnvPhb4PecStack { > /* The owner PEC */ > PnvPhb4PecState *pec; > > - /* The actual PHB */ > - PnvPHB4 phb; > + /* > + * PHB4 pointer. pnv_phb4_update_regions() needs to access > + * the PHB4 via a PnvPhb4PecStack pointer. > + */ > + PnvPHB4 *phb; > }; > > struct PnvPhb4PecState { >
On 1/5/22 22:23, Daniel Henrique Barboza wrote: > At this moment, stack->phb is the plain PnvPHB4 device itself instead > of a pointer to the device. This will present a problem when adding user > creatable devices because we can't deal with this struct and the > realize() callback from the user creatable device. > > We can't get rid of this attribute, similar to what we did when enabling > pnv-phb3 user creatable devices, because pnv_phb4_update_regions() needs > to access stack->phb to do its job. This function is called twice in > pnv_pec_stk_update_map(), which is one of the nested xscom write > callbacks (via pnv_pec_stk_nest_xscom_write()). In fact, > pnv_pec_stk_update_map() code comment is explicit about how the order of > the unmap/map operations relates with the PHB subregions. > > All of this indicates that this code is tied together in a way that we > either go on a crusade, featuring lots of refactories and redesign and > considerable pain, to decouple stack and phb mapping, or we allow stack > update_map operations to access the associated PHB as it is today even > after introducing pnv-phb4 user devices. > > This patch chooses the latter. Instead of getting rid of stack->phb, > turn it into a PHB pointer. This will allow us to assign an user created > PHB to an existing stack later. > > Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> > --- > hw/pci-host/pnv_phb4.c | 2 +- > hw/pci-host/pnv_phb4_pec.c | 2 +- > include/hw/pci-host/pnv_phb4.h | 7 +++++-- > 3 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c > index 4c785bbe4c..9e670e41d2 100644 > --- a/hw/pci-host/pnv_phb4.c > +++ b/hw/pci-host/pnv_phb4.c > @@ -1449,7 +1449,7 @@ type_init(pnv_phb4_register_types); > > void pnv_phb4_update_regions(PnvPhb4PecStack *stack) > { > - PnvPHB4 *phb = &stack->phb; > + PnvPHB4 *phb = stack->phb; > > /* Unmap first always */ > if (memory_region_is_mapped(&phb->mr_regs)) { > diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host/pnv_phb4_pec.c > index 0675fc55bc..be6eefdbb1 100644 > --- a/hw/pci-host/pnv_phb4_pec.c > +++ b/hw/pci-host/pnv_phb4_pec.c > @@ -563,7 +563,7 @@ static void pnv_pec_stk_realize(DeviceState *dev, Error **errp) > PHB4_PEC_PCI_STK_REGS_COUNT); > > /* PHB pass-through */ > - pnv_phb4_set_stack_phb_props(stack, &stack->phb); > + pnv_phb4_set_stack_phb_props(stack, stack->phb); > if (!sysbus_realize(SYS_BUS_DEVICE(&stack->phb), errp)) { > return; > } > diff --git a/include/hw/pci-host/pnv_phb4.h b/include/hw/pci-host/pnv_phb4.h > index b2c4a6b263..2fb5e119c4 100644 > --- a/include/hw/pci-host/pnv_phb4.h > +++ b/include/hw/pci-host/pnv_phb4.h > @@ -178,8 +178,11 @@ struct PnvPhb4PecStack { > /* The owner PEC */ > PnvPhb4PecState *pec; > > - /* The actual PHB */ > - PnvPHB4 phb; I would keep this object for default_enabled() and rename it to avoid conflicts with the next one : > + /* > + * PHB4 pointer. pnv_phb4_update_regions() needs to access > + * the PHB4 via a PnvPhb4PecStack pointer. > + */ > + PnvPHB4 *phb; and introduce this pointer for dynamic phbs. if default_enabled(), then just make it point to the above instance. Thanks, C. > }; > > struct PnvPhb4PecState { >
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index 4c785bbe4c..9e670e41d2 100644 --- a/hw/pci-host/pnv_phb4.c +++ b/hw/pci-host/pnv_phb4.c @@ -1449,7 +1449,7 @@ type_init(pnv_phb4_register_types); void pnv_phb4_update_regions(PnvPhb4PecStack *stack) { - PnvPHB4 *phb = &stack->phb; + PnvPHB4 *phb = stack->phb; /* Unmap first always */ if (memory_region_is_mapped(&phb->mr_regs)) { diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host/pnv_phb4_pec.c index 0675fc55bc..be6eefdbb1 100644 --- a/hw/pci-host/pnv_phb4_pec.c +++ b/hw/pci-host/pnv_phb4_pec.c @@ -563,7 +563,7 @@ static void pnv_pec_stk_realize(DeviceState *dev, Error **errp) PHB4_PEC_PCI_STK_REGS_COUNT); /* PHB pass-through */ - pnv_phb4_set_stack_phb_props(stack, &stack->phb); + pnv_phb4_set_stack_phb_props(stack, stack->phb); if (!sysbus_realize(SYS_BUS_DEVICE(&stack->phb), errp)) { return; } diff --git a/include/hw/pci-host/pnv_phb4.h b/include/hw/pci-host/pnv_phb4.h index b2c4a6b263..2fb5e119c4 100644 --- a/include/hw/pci-host/pnv_phb4.h +++ b/include/hw/pci-host/pnv_phb4.h @@ -178,8 +178,11 @@ struct PnvPhb4PecStack { /* The owner PEC */ PnvPhb4PecState *pec; - /* The actual PHB */ - PnvPHB4 phb; + /* + * PHB4 pointer. pnv_phb4_update_regions() needs to access + * the PHB4 via a PnvPhb4PecStack pointer. + */ + PnvPHB4 *phb; }; struct PnvPhb4PecState {
At this moment, stack->phb is the plain PnvPHB4 device itself instead of a pointer to the device. This will present a problem when adding user creatable devices because we can't deal with this struct and the realize() callback from the user creatable device. We can't get rid of this attribute, similar to what we did when enabling pnv-phb3 user creatable devices, because pnv_phb4_update_regions() needs to access stack->phb to do its job. This function is called twice in pnv_pec_stk_update_map(), which is one of the nested xscom write callbacks (via pnv_pec_stk_nest_xscom_write()). In fact, pnv_pec_stk_update_map() code comment is explicit about how the order of the unmap/map operations relates with the PHB subregions. All of this indicates that this code is tied together in a way that we either go on a crusade, featuring lots of refactories and redesign and considerable pain, to decouple stack and phb mapping, or we allow stack update_map operations to access the associated PHB as it is today even after introducing pnv-phb4 user devices. This patch chooses the latter. Instead of getting rid of stack->phb, turn it into a PHB pointer. This will allow us to assign an user created PHB to an existing stack later. Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> --- hw/pci-host/pnv_phb4.c | 2 +- hw/pci-host/pnv_phb4_pec.c | 2 +- include/hw/pci-host/pnv_phb4.h | 7 +++++-- 3 files changed, 7 insertions(+), 4 deletions(-)