| Message ID | 20220104091240.160867-1-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | gitlab-ci: Enable docs in the centos job | expand |
On Tue, Jan 4, 2022 at 1:12 PM Thomas Huth <thuth@redhat.com> wrote: > > We just ran into a problem that the docs don't build on RHEL8 / CentOS 8 > anymore. Seems like these distros are using one of the oldest Sphinx > versions that we still have to support. Thus enable the docs build in > the CI on CentOS so that such bugs don't slip in so easily again. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > Based-on: <20220104074649.1712440-1-marcandre.lureau@redhat.com> > > .gitlab-ci.d/buildtest.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml > index d52fde23ec..083d1b25e5 100644 > --- a/.gitlab-ci.d/buildtest.yml > +++ b/.gitlab-ci.d/buildtest.yml > @@ -164,7 +164,7 @@ build-system-centos: > variables: > IMAGE: centos8 > CONFIGURE_ARGS: --disable-nettle --enable-gcrypt --enable-fdt=system > - --enable-modules --enable-trace-backends=dtrace > + --enable-modules --enable-trace-backends=dtrace --enable-docs > TARGETS: ppc64-softmmu or1k-softmmu s390x-softmmu > x86_64-softmmu rx-softmmu sh4-softmmu nios2-softmmu > MAKE_CHECK_ARGS: check-build > -- > 2.27.0 >
On Tue, Jan 4, 2022 at 10:12 AM Thomas Huth <thuth@redhat.com> wrote: > > We just ran into a problem that the docs don't build on RHEL8 / CentOS 8 > anymore. Seems like these distros are using one of the oldest Sphinx > versions that we still have to support. Thus enable the docs build in > the CI on CentOS so that such bugs don't slip in so easily again. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > Based-on: <20220104074649.1712440-1-marcandre.lureau@redhat.com> > > .gitlab-ci.d/buildtest.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Thomas Huth <thuth@redhat.com> writes: > We just ran into a problem that the docs don't build on RHEL8 / CentOS 8 > anymore. Seems like these distros are using one of the oldest Sphinx > versions that we still have to support. Thus enable the docs build in > the CI on CentOS so that such bugs don't slip in so easily again. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Queued to testing/next, thanks.
On 05/01/2022 10.44, Alex Bennée wrote: > > Thomas Huth <thuth@redhat.com> writes: > >> We just ran into a problem that the docs don't build on RHEL8 / CentOS 8 >> anymore. Seems like these distros are using one of the oldest Sphinx >> versions that we still have to support. Thus enable the docs build in >> the CI on CentOS so that such bugs don't slip in so easily again. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> > > Queued to testing/next, thanks. Note that you need Marc-André's fix first, too. But I'm also planning a pull request with a bunch of misc other patches soon, so I can also stick these two patches in there, too. Thomas
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index d52fde23ec..083d1b25e5 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -164,7 +164,7 @@ build-system-centos: variables: IMAGE: centos8 CONFIGURE_ARGS: --disable-nettle --enable-gcrypt --enable-fdt=system - --enable-modules --enable-trace-backends=dtrace + --enable-modules --enable-trace-backends=dtrace --enable-docs TARGETS: ppc64-softmmu or1k-softmmu s390x-softmmu x86_64-softmmu rx-softmmu sh4-softmmu nios2-softmmu MAKE_CHECK_ARGS: check-build
We just ran into a problem that the docs don't build on RHEL8 / CentOS 8 anymore. Seems like these distros are using one of the oldest Sphinx versions that we still have to support. Thus enable the docs build in the CI on CentOS so that such bugs don't slip in so easily again. Signed-off-by: Thomas Huth <thuth@redhat.com> --- Based-on: <20220104074649.1712440-1-marcandre.lureau@redhat.com> .gitlab-ci.d/buildtest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)