| Message ID | 20220103185332.117878-6-danielhb413@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Reorg ppc64 pmu insn counting | expand |
On 1/3/22 10:53 AM, Daniel Henrique Barboza wrote: > MMCR0 writes will change only MMCR0 bits which are used to calculate > HFLAGS_PMCC0, HFLAGS_PMCC1 and HFLAGS_INSN_CNT hflags. No other machine > register will be changed during this operation. This means that > hreg_compute_hflags() is overkill for what we need to do. > > pmu_update_summaries() is already updating HFLAGS_INSN_CNT without > calling hreg_compure_hflags(). Let's do the same for the other 2 MMCR0 > hflags. > > Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> > --- > target/ppc/power8-pmu.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/target/ppc/power8-pmu.c b/target/ppc/power8-pmu.c > index 73713ca2a3..69342413bd 100644 > --- a/target/ppc/power8-pmu.c > +++ b/target/ppc/power8-pmu.c > @@ -224,12 +224,17 @@ static void pmu_update_overflow_timers(CPUPPCState *env) > > void helper_store_mmcr0(CPUPPCState *env, target_ulong value) > { > + uint32_t hflags_pmcc0 = (value & MMCR0_PMCC0) != 0; > + uint32_t hflags_pmcc1 = (value & MMCR0_PMCC1) != 0; Could use bool here. Otherwise, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/ppc/power8-pmu.c b/target/ppc/power8-pmu.c index 73713ca2a3..69342413bd 100644 --- a/target/ppc/power8-pmu.c +++ b/target/ppc/power8-pmu.c @@ -224,12 +224,17 @@ static void pmu_update_overflow_timers(CPUPPCState *env) void helper_store_mmcr0(CPUPPCState *env, target_ulong value) { + uint32_t hflags_pmcc0 = (value & MMCR0_PMCC0) != 0; + uint32_t hflags_pmcc1 = (value & MMCR0_PMCC1) != 0; + pmu_update_cycles(env); env->spr[SPR_POWER_MMCR0] = value; /* MMCR0 writes can change HFLAGS_PMCC[01] and HFLAGS_INSN_CNT */ - hreg_compute_hflags(env); + env->hflags = deposit32(env->hflags, HFLAGS_PMCC0, 1, hflags_pmcc0); + env->hflags = deposit32(env->hflags, HFLAGS_PMCC1, 1, hflags_pmcc1); + pmu_update_summaries(env); /* Update cycle overflow timers with the current MMCR0 state */
MMCR0 writes will change only MMCR0 bits which are used to calculate HFLAGS_PMCC0, HFLAGS_PMCC1 and HFLAGS_INSN_CNT hflags. No other machine register will be changed during this operation. This means that hreg_compute_hflags() is overkill for what we need to do. pmu_update_summaries() is already updating HFLAGS_INSN_CNT without calling hreg_compure_hflags(). Let's do the same for the other 2 MMCR0 hflags. Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> --- target/ppc/power8-pmu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)