diff mbox series

[for-7.0,3/4] target/rx/cpu.h: Don't include qemu-common.h

Message ID 20211129200510.1233037-4-peter.maydell@linaro.org
State New
Headers show
Series qemu-common.h include cleanup | expand

Commit Message

Peter Maydell Nov. 29, 2021, 8:05 p.m. UTC
The qemu-common.h header is not supposed to be included from any
other header files, only from .c files (as documented in a comment at
the start of it).

Nothing actually relies on target/rx/cpu.h including it, so we can
just drop the include.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/rx/cpu.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Yoshinori Sato Dec. 1, 2021, 12:26 p.m. UTC | #1
On Tue, 30 Nov 2021 05:05:09 +0900,
Peter Maydell wrote:
> 
> The qemu-common.h header is not supposed to be included from any
> other header files, only from .c files (as documented in a comment at
> the start of it).
> 
> Nothing actually relies on target/rx/cpu.h including it, so we can
> just drop the include.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

> ---
>  target/rx/cpu.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/rx/cpu.h b/target/rx/cpu.h
> index 4ac71aec370..657db84ef0a 100644
> --- a/target/rx/cpu.h
> +++ b/target/rx/cpu.h
> @@ -20,7 +20,6 @@
>  #define RX_CPU_H
>  
>  #include "qemu/bitops.h"
> -#include "qemu-common.h"
>  #include "hw/registerfields.h"
>  #include "cpu-qom.h"
>  
> -- 
> 2.25.1
> 
>
diff mbox series

Patch

diff --git a/target/rx/cpu.h b/target/rx/cpu.h
index 4ac71aec370..657db84ef0a 100644
--- a/target/rx/cpu.h
+++ b/target/rx/cpu.h
@@ -20,7 +20,6 @@ 
 #define RX_CPU_H
 
 #include "qemu/bitops.h"
-#include "qemu-common.h"
 #include "hw/registerfields.h"
 #include "cpu-qom.h"