Message ID | 20211124092948.335389-3-danielhb413@gmail.com |
---|---|
State | New |
Headers | show |
Series | change ivshmem endianness to LITTLE_ENDIAN | expand |
On 11/24/21 10:29, Daniel Henrique Barboza wrote: > This test, if enabled by hand, was failing when the ivhsmem device was > being declared as DEVICE_NATIVE_ENDIAN with the following error: > > /ppc64/ivshmem/pair: OK > /ppc64/ivshmem/server: > ** > ERROR:/home/danielhb/qemu/tests/qtest/ivshmem-test.c:367:test_ivshmem_server: > assertion failed (ret != 0): (0 != 0) > Aborted > > After the endianness change done in the previous patch, we can verify in > both a a Power 9 little-endian host and in a Power 8 big-endian host > that this test is now passing: > > $ QTEST_QEMU_BINARY=./ppc64-softmmu/qemu-system-ppc64 ./tests/qtest/ivshmem-test -m slow > /ppc64/ivshmem/single: OK > /ppc64/ivshmem/hotplug: OK > /ppc64/ivshmem/memdev: OK > /ppc64/ivshmem/pair: OK > /ppc64/ivshmem/server: OK > > Let's keep it that way by officially enabling it for ppc64. > > Acked-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> > --- > tests/qtest/ivshmem-test.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c index dfa69424ed..fe94dd3b96 100644 --- a/tests/qtest/ivshmem-test.c +++ b/tests/qtest/ivshmem-test.c @@ -463,7 +463,6 @@ static gchar *mktempshm(int size, int *fd) int main(int argc, char **argv) { int ret, fd; - const char *arch = qtest_get_arch(); gchar dir[] = "/tmp/ivshmem-test.XXXXXX"; g_test_init(&argc, &argv, NULL); @@ -488,9 +487,7 @@ int main(int argc, char **argv) qtest_add_func("/ivshmem/memdev", test_ivshmem_memdev); if (g_test_slow()) { qtest_add_func("/ivshmem/pair", test_ivshmem_pair); - if (strcmp(arch, "ppc64") != 0) { - qtest_add_func("/ivshmem/server", test_ivshmem_server); - } + qtest_add_func("/ivshmem/server", test_ivshmem_server); } out: