| Message ID | 20211112193431.2379298-2-eperezma@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | vdpa: Check for existence of opts.vhostdev | expand |
On Sat, Nov 13, 2021 at 3:34 AM Eugenio Pérez <eperezma@redhat.com> wrote: > > There is no reason to keep using the old one, since we neither use the > variadics arguments nor open it with O_DIRECT. > > Also, net_client_init1, the caller of net_init_vhost_vdpa, wants all > net_client_init_fun to use Error API, so it's a good step in that > direction. > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > net/vhost-vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > index 49ab322511..6ffb29f4da 100644 > --- a/net/vhost-vdpa.c > +++ b/net/vhost-vdpa.c > @@ -261,7 +261,7 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name, > assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA); > opts = &netdev->u.vhost_vdpa; > > - vdpa_device_fd = qemu_open_old(opts->vhostdev, O_RDWR); > + vdpa_device_fd = qemu_open(opts->vhostdev, O_RDWR, errp); > if (vdpa_device_fd == -1) { > return -errno; > } > -- > 2.27.0 >
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 49ab322511..6ffb29f4da 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -261,7 +261,7 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name, assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA); opts = &netdev->u.vhost_vdpa; - vdpa_device_fd = qemu_open_old(opts->vhostdev, O_RDWR); + vdpa_device_fd = qemu_open(opts->vhostdev, O_RDWR, errp); if (vdpa_device_fd == -1) { return -errno; }
There is no reason to keep using the old one, since we neither use the variadics arguments nor open it with O_DIRECT. Also, net_client_init1, the caller of net_init_vhost_vdpa, wants all net_client_init_fun to use Error API, so it's a good step in that direction. Signed-off-by: Eugenio Pérez <eperezma@redhat.com> --- net/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)