| Message ID | 20211111110604.207376-2-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Update linux-headers + NOIRQ support for KVM gdbstub | expand |
On Thu, Nov 11 2021, Paolo Bonzini <pbonzini@redhat.com> wrote: > In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a > single-byte field followed by a uint8_t[3] array of padding bytes, > and virtio_gpu_ctrl_hdr_bswap does not compile anymore. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > include/hw/virtio/virtio-gpu-bswap.h | 1 - > 1 file changed, 1 deletion(-) Looks like the right way to adapt to the changes. Acked-by: Cornelia Huck <cohuck@redhat.com>
On 11/11/21 12:06, Paolo Bonzini wrote: > In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a > single-byte field followed by a uint8_t[3] array of padding bytes, > and virtio_gpu_ctrl_hdr_bswap does not compile anymore. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > include/hw/virtio/virtio-gpu-bswap.h | 1 - > 1 file changed, 1 deletion(-) :) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Thu, Nov 11, 2021 at 12:06:00PM +0100, Paolo Bonzini wrote: > In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a > single-byte field followed by a uint8_t[3] array of padding bytes, > and virtio_gpu_ctrl_hdr_bswap does not compile anymore. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> No idea why we bothered swapping it anyway. > --- > include/hw/virtio/virtio-gpu-bswap.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/hw/virtio/virtio-gpu-bswap.h b/include/hw/virtio/virtio-gpu-bswap.h > index e2bee8f595..5faac0d8d5 100644 > --- a/include/hw/virtio/virtio-gpu-bswap.h > +++ b/include/hw/virtio/virtio-gpu-bswap.h > @@ -24,7 +24,6 @@ virtio_gpu_ctrl_hdr_bswap(struct virtio_gpu_ctrl_hdr *hdr) > le32_to_cpus(&hdr->flags); > le64_to_cpus(&hdr->fence_id); > le32_to_cpus(&hdr->ctx_id); > - le32_to_cpus(&hdr->padding); > } > > static inline void > -- > 2.33.1 >
Paolo Bonzini <pbonzini@redhat.com> writes: > In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a > single-byte field followed by a uint8_t[3] array of padding bytes, > and virtio_gpu_ctrl_hdr_bswap does not compile anymore. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/include/hw/virtio/virtio-gpu-bswap.h b/include/hw/virtio/virtio-gpu-bswap.h index e2bee8f595..5faac0d8d5 100644 --- a/include/hw/virtio/virtio-gpu-bswap.h +++ b/include/hw/virtio/virtio-gpu-bswap.h @@ -24,7 +24,6 @@ virtio_gpu_ctrl_hdr_bswap(struct virtio_gpu_ctrl_hdr *hdr) le32_to_cpus(&hdr->flags); le64_to_cpus(&hdr->fence_id); le32_to_cpus(&hdr->ctx_id); - le32_to_cpus(&hdr->padding); } static inline void
In Linux 5.16, the padding of struct virtio_gpu_ctrl_hdr has become a single-byte field followed by a uint8_t[3] array of padding bytes, and virtio_gpu_ctrl_hdr_bswap does not compile anymore. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- include/hw/virtio/virtio-gpu-bswap.h | 1 - 1 file changed, 1 deletion(-)