Message ID | 20211030095225.513D4748F48@zero.eik.bme.hu |
---|---|
State | New |
Headers | show |
Series | [v2] hmp: Add shortcut to stop command to match cont | expand |
Ping? This is really simple addition that sholdn't take long to review. On Sat, 30 Oct 2021, BALATON Zoltan wrote: > Some commands such as quit or cont have one letter alternatives but > stop is missing that. Add stop|s to match cont|c for consistency and > convenience. > > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> > --- > c2: Fixed typo in commit title > > hmp-commands.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index cf723c69ac..07a738a8e2 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -382,7 +382,7 @@ SRST > ERST > > { > - .name = "stop", > + .name = "stop|s", > .args_type = "", > .params = "", > .help = "stop emulation", > @@ -390,7 +390,7 @@ ERST > }, > > SRST > -``stop`` > +``stop`` or ``s`` > Stop emulation. > ERST > >
On Sat, Oct 30, 2021 at 11:49:37AM +0200, BALATON Zoltan wrote: > Some commands such as quit or cont have one letter alternatives but > stop is missing that. Add stop|s to match cont|c for consistency and > convenience. > > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> > --- > c2: Fixed typo in commit title > > hmp-commands.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
Le 01/11/2021 à 23:56, BALATON Zoltan a écrit : > Ping? This is really simple addition that sholdn't take long to review. > > On Sat, 30 Oct 2021, BALATON Zoltan wrote: >> Some commands such as quit or cont have one letter alternatives but >> stop is missing that. Add stop|s to match cont|c for consistency and >> convenience. >> >> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> >> --- >> c2: Fixed typo in commit title >> >> hmp-commands.hx | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/hmp-commands.hx b/hmp-commands.hx >> index cf723c69ac..07a738a8e2 100644 >> --- a/hmp-commands.hx >> +++ b/hmp-commands.hx >> @@ -382,7 +382,7 @@ SRST >> ERST >> >> { >> - .name = "stop", >> + .name = "stop|s", >> .args_type = "", >> .params = "", >> .help = "stop emulation", >> @@ -390,7 +390,7 @@ ERST >> }, >> >> SRST >> -``stop`` >> +``stop`` or ``s`` >> Stop emulation. >> ERST >> >> > Applied to my trivial-patches branch. I'll do a new PR before the hard freeze. Thanks, Laurent
diff --git a/hmp-commands.hx b/hmp-commands.hx index cf723c69ac..07a738a8e2 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -382,7 +382,7 @@ SRST ERST { - .name = "stop", + .name = "stop|s", .args_type = "", .params = "", .help = "stop emulation", @@ -390,7 +390,7 @@ ERST }, SRST -``stop`` +``stop`` or ``s`` Stop emulation. ERST
Some commands such as quit or cont have one letter alternatives but stop is missing that. Add stop|s to match cont|c for consistency and convenience. Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- c2: Fixed typo in commit title hmp-commands.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)