| Message ID | 20211028155457.967291-2-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | monitor: explicitly permit QMP commands to be added for all use cases | expand |
On Thu, Oct 28, 2021 at 04:54:36PM +0100, Daniel P. Berrangé wrote: > This command was turned into a no-op four years ago in > > commit 0c8465440d50c18a7bb13d0a866748f0593e193a > Author: Peter Xu <peterx@redhat.com> > Date: Fri Dec 29 15:31:04 2017 +0800 > > hmp: obsolete "info ioapic" > > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Peter Xu <peterx@redhat.com>
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 4c966e8a6b..24c478aead 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -127,21 +127,6 @@ SRST Show local APIC state ERST -#if defined(TARGET_I386) - { - .name = "ioapic", - .args_type = "", - .params = "", - .help = "show io apic state", - .cmd = hmp_info_io_apic, - }, -#endif - -SRST - ``info ioapic`` - Show io APIC state -ERST - { .name = "cpus", .args_type = "", diff --git a/include/monitor/hmp-target.h b/include/monitor/hmp-target.h index 96956d0fc4..ffdc15a34b 100644 --- a/include/monitor/hmp-target.h +++ b/include/monitor/hmp-target.h @@ -48,7 +48,6 @@ void hmp_info_mem(Monitor *mon, const QDict *qdict); void hmp_info_tlb(Monitor *mon, const QDict *qdict); void hmp_mce(Monitor *mon, const QDict *qdict); void hmp_info_local_apic(Monitor *mon, const QDict *qdict); -void hmp_info_io_apic(Monitor *mon, const QDict *qdict); void hmp_info_sev(Monitor *mon, const QDict *qdict); void hmp_info_sgx(Monitor *mon, const QDict *qdict); diff --git a/target/i386/monitor.c b/target/i386/monitor.c index 8166e17693..8e4b4d600c 100644 --- a/target/i386/monitor.c +++ b/target/i386/monitor.c @@ -667,9 +667,3 @@ void hmp_info_local_apic(Monitor *mon, const QDict *qdict) } x86_cpu_dump_local_apic_state(cs, CPU_DUMP_FPU); } - -void hmp_info_io_apic(Monitor *mon, const QDict *qdict) -{ - monitor_printf(mon, "This command is obsolete and will be " - "removed soon. Please use 'info pic' instead.\n"); -}
This command was turned into a no-op four years ago in commit 0c8465440d50c18a7bb13d0a866748f0593e193a Author: Peter Xu <peterx@redhat.com> Date: Fri Dec 29 15:31:04 2017 +0800 hmp: obsolete "info ioapic" Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- hmp-commands-info.hx | 15 --------------- include/monitor/hmp-target.h | 1 - target/i386/monitor.c | 6 ------ 3 files changed, 22 deletions(-)