diff mbox series

[v8,35/40] target/sparc: Remove pointless use of CONFIG_TCG definition

Message ID 20210926222716.1732932-36-f4bug@amsat.org
State New
Headers show
Series accel: Move has_work() from CPUClass to AccelOpsClass | expand

Commit Message

Philippe Mathieu-Daudé Sept. 26, 2021, 10:27 p.m. UTC
The SPARC target only support TCG acceleration. Remove the CONFIG_TCG
definition introduced by mistake in commit 78271684719 ("cpu: tcg_ops:
move to tcg-cpu-ops.h, keep a pointer in CPUClass").

Reported-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/sparc/cpu.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Mark Cave-Ayland Sept. 29, 2021, 7:06 a.m. UTC | #1
On 26/09/2021 23:27, Philippe Mathieu-Daudé wrote:

> The SPARC target only support TCG acceleration. Remove the CONFIG_TCG
> definition introduced by mistake in commit 78271684719 ("cpu: tcg_ops:
> move to tcg-cpu-ops.h, keep a pointer in CPUClass").
> 
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   target/sparc/cpu.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
> index 21dd27796d0..0d252cb5bdc 100644
> --- a/target/sparc/cpu.c
> +++ b/target/sparc/cpu.c
> @@ -859,7 +859,6 @@ static const struct SysemuCPUOps sparc_sysemu_ops = {
>   };
>   #endif
>   
> -#ifdef CONFIG_TCG
>   #include "hw/core/tcg-cpu-ops.h"
>   
>   static const struct TCGCPUOps sparc_tcg_ops = {
> @@ -874,7 +873,6 @@ static const struct TCGCPUOps sparc_tcg_ops = {
>       .do_unaligned_access = sparc_cpu_do_unaligned_access,
>   #endif /* !CONFIG_USER_ONLY */
>   };
> -#endif /* CONFIG_TCG */
>   
>   static void sparc_cpu_class_init(ObjectClass *oc, void *data)
>   {

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.
diff mbox series

Patch

diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index 21dd27796d0..0d252cb5bdc 100644
--- a/target/sparc/cpu.c
+++ b/target/sparc/cpu.c
@@ -859,7 +859,6 @@  static const struct SysemuCPUOps sparc_sysemu_ops = {
 };
 #endif
 
-#ifdef CONFIG_TCG
 #include "hw/core/tcg-cpu-ops.h"
 
 static const struct TCGCPUOps sparc_tcg_ops = {
@@ -874,7 +873,6 @@  static const struct TCGCPUOps sparc_tcg_ops = {
     .do_unaligned_access = sparc_cpu_do_unaligned_access,
 #endif /* !CONFIG_USER_ONLY */
 };
-#endif /* CONFIG_TCG */
 
 static void sparc_cpu_class_init(ObjectClass *oc, void *data)
 {