| Message ID | 20210924185506.2542588-6-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Acceptance Tests: use Avocado 91.0 features and other improvements | expand |
Hi, Cleber, On Fri, Sep 24, 2021 at 3:57 PM Cleber Rosa <crosa@redhat.com> wrote: > > The avocado.Test class, used as the basis of the avocado_qemu.Test > class, performs a clean of temporary directories up as part of its own > tearDown() implementation. > > But the avocado_qemu.Test class is currently missing the same clean > up, as it implemented its own tearDown() method without resorting to > the upper class behavior. > > This brings avocado_qemu.Test behavior in sync with the standard > avocado.Test behavior and prevents temporary directories from > cluttering the test results directory (unless instructed to do so with > Avocado's "--keep-tmp" option). > > Reported-by: Peter Maydell <peter.maydell@linaro.org> > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/avocado_qemu/__init__.py | 1 + > 1 file changed, 1 insertion(+) > There was a comment from Wainer in the original patch and as you were on vacation I submitted a respin last Monday: https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05117.html I also did some refactoring/fixes to the avocado_qemu here: https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05212.html
diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index 2c4fef3e14..1e807e2e55 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b/tests/acceptance/avocado_qemu/__init__.py @@ -276,6 +276,7 @@ def tearDown(self): for vm in self._vms.values(): vm.shutdown() self._sd = None + super(Test, self).tearDown() def fetch_asset(self, name, asset_hash=None, algorithm=None,
The avocado.Test class, used as the basis of the avocado_qemu.Test class, performs a clean of temporary directories up as part of its own tearDown() implementation. But the avocado_qemu.Test class is currently missing the same clean up, as it implemented its own tearDown() method without resorting to the upper class behavior. This brings avocado_qemu.Test behavior in sync with the standard avocado.Test behavior and prevents temporary directories from cluttering the test results directory (unless instructed to do so with Avocado's "--keep-tmp" option). Reported-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Cleber Rosa <crosa@redhat.com> --- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+)