| Message ID | 20210903081358.956267-3-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Use meson_options.txt in the configure script | expand |
On Fri, Sep 03, 2021 at 10:13:55AM +0200, Thomas Huth wrote: > There is no reason why VNC should always be enabled and not be set to > the default value. We already switched the setting in the "configure" > script in commit 3a6a1256d4 ("configure: Allow vnc to get disabled with > --without-default-features"), so let's do that in meson_options.txt now, > too. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > meson_options.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/meson_options.txt b/meson_options.txt > index a9a9b8f4c6..2c89e79e8b 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -120,7 +120,7 @@ option('usb_redir', type : 'feature', value : 'auto', > description: 'libusbredir support') > option('virglrenderer', type : 'feature', value : 'auto', > description: 'virgl rendering support') > -option('vnc', type : 'feature', value : 'enabled', > +option('vnc', type : 'feature', value : 'auto', > description: 'VNC server') > option('vnc_jpeg', type : 'feature', value : 'auto', > description: 'JPEG lossy compression for VNC server') > -- > 2.27.0 >
On 03/09/21 10:13, Thomas Huth wrote: > There is no reason why VNC should always be enabled and not be set to > the default value. We already switched the setting in the "configure" > script in commit 3a6a1256d4 ("configure: Allow vnc to get disabled with > --without-default-features"), so let's do that in meson_options.txt now, > too. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > meson_options.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson_options.txt b/meson_options.txt > index a9a9b8f4c6..2c89e79e8b 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -120,7 +120,7 @@ option('usb_redir', type : 'feature', value : 'auto', > description: 'libusbredir support') > option('virglrenderer', type : 'feature', value : 'auto', > description: 'virgl rendering support') > -option('vnc', type : 'feature', value : 'enabled', > +option('vnc', type : 'feature', value : 'auto', > description: 'VNC server') > option('vnc_jpeg', type : 'feature', value : 'auto', > description: 'JPEG lossy compression for VNC server') > Queued this one for now, thanks. Paolo
diff --git a/meson_options.txt b/meson_options.txt index a9a9b8f4c6..2c89e79e8b 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -120,7 +120,7 @@ option('usb_redir', type : 'feature', value : 'auto', description: 'libusbredir support') option('virglrenderer', type : 'feature', value : 'auto', description: 'virgl rendering support') -option('vnc', type : 'feature', value : 'enabled', +option('vnc', type : 'feature', value : 'auto', description: 'VNC server') option('vnc_jpeg', type : 'feature', value : 'auto', description: 'JPEG lossy compression for VNC server')
There is no reason why VNC should always be enabled and not be set to the default value. We already switched the setting in the "configure" script in commit 3a6a1256d4 ("configure: Allow vnc to get disabled with --without-default-features"), so let's do that in meson_options.txt now, too. Signed-off-by: Thomas Huth <thuth@redhat.com> --- meson_options.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)