| Message ID | 20210819031525.653995-2-tong.ho@xilinx.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw/arm/xlnx-versal: hw/arm/xlnx-zynqmp: Add unimplemented mmio | expand |
On Thu, Aug 19, 2021 at 1:20 PM Tong Ho <tong.ho@xilinx.com> wrote: > > Add unimplemented APU mmio region to xlnx-versal for booting > bare-metal guests built with standalone bsp published at: > https://github.com/Xilinx/embeddedsw/tree/master/lib/bsp/standalone/src/arm/ARMv8/64bit > > Signed-off-by: Tong Ho <tong.ho@xilinx.com> Acked-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/arm/xlnx-versal.c | 2 ++ > include/hw/arm/xlnx-versal.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c > index fb776834f7..cb6ec0a4a0 100644 > --- a/hw/arm/xlnx-versal.c > +++ b/hw/arm/xlnx-versal.c > @@ -376,6 +376,8 @@ static void versal_unimp(Versal *s) > MM_CRL, MM_CRL_SIZE); > versal_unimp_area(s, "crf", &s->mr_ps, > MM_FPD_CRF, MM_FPD_CRF_SIZE); > + versal_unimp_area(s, "apu", &s->mr_ps, > + MM_FPD_FPD_APU, MM_FPD_FPD_APU_SIZE); > versal_unimp_area(s, "crp", &s->mr_ps, > MM_PMC_CRP, MM_PMC_CRP_SIZE); > versal_unimp_area(s, "iou-scntr", &s->mr_ps, > diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h > index 22a8fa5d11..9b79051747 100644 > --- a/include/hw/arm/xlnx-versal.h > +++ b/include/hw/arm/xlnx-versal.h > @@ -167,6 +167,8 @@ struct Versal { > #define MM_IOU_SCNTRS_SIZE 0x10000 > #define MM_FPD_CRF 0xfd1a0000U > #define MM_FPD_CRF_SIZE 0x140000 > +#define MM_FPD_FPD_APU 0xfd5c0000 > +#define MM_FPD_FPD_APU_SIZE 0x100 > > #define MM_PMC_SD0 0xf1040000U > #define MM_PMC_SD0_SIZE 0x10000 > -- > 2.25.1 > >
On Wed, Aug 18, 2021 at 08:15:24PM -0700, Tong Ho wrote: > Add unimplemented APU mmio region to xlnx-versal for booting > bare-metal guests built with standalone bsp published at: > https://github.com/Xilinx/embeddedsw/tree/master/lib/bsp/standalone/src/arm/ARMv8/64bit Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > Signed-off-by: Tong Ho <tong.ho@xilinx.com> > --- > hw/arm/xlnx-versal.c | 2 ++ > include/hw/arm/xlnx-versal.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c > index fb776834f7..cb6ec0a4a0 100644 > --- a/hw/arm/xlnx-versal.c > +++ b/hw/arm/xlnx-versal.c > @@ -376,6 +376,8 @@ static void versal_unimp(Versal *s) > MM_CRL, MM_CRL_SIZE); > versal_unimp_area(s, "crf", &s->mr_ps, > MM_FPD_CRF, MM_FPD_CRF_SIZE); > + versal_unimp_area(s, "apu", &s->mr_ps, > + MM_FPD_FPD_APU, MM_FPD_FPD_APU_SIZE); > versal_unimp_area(s, "crp", &s->mr_ps, > MM_PMC_CRP, MM_PMC_CRP_SIZE); > versal_unimp_area(s, "iou-scntr", &s->mr_ps, > diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h > index 22a8fa5d11..9b79051747 100644 > --- a/include/hw/arm/xlnx-versal.h > +++ b/include/hw/arm/xlnx-versal.h > @@ -167,6 +167,8 @@ struct Versal { > #define MM_IOU_SCNTRS_SIZE 0x10000 > #define MM_FPD_CRF 0xfd1a0000U > #define MM_FPD_CRF_SIZE 0x140000 > +#define MM_FPD_FPD_APU 0xfd5c0000 > +#define MM_FPD_FPD_APU_SIZE 0x100 > > #define MM_PMC_SD0 0xf1040000U > #define MM_PMC_SD0_SIZE 0x10000 > -- > 2.25.1 >
On 8/19/21 5:15 AM, Tong Ho wrote: > Add unimplemented APU mmio region to xlnx-versal for booting > bare-metal guests built with standalone bsp published at: > https://github.com/Xilinx/embeddedsw/tree/master/lib/bsp/standalone/src/arm/ARMv8/64bit This link is not very useful. This one is: https://github.com/Xilinx/embeddedsw/blob/master-rel-2020.2/lib/sw_apps/versal_psmfw/src/fpd_apu.h > > Signed-off-by: Tong Ho <tong.ho@xilinx.com> > --- > hw/arm/xlnx-versal.c | 2 ++ > include/hw/arm/xlnx-versal.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c > index fb776834f7..cb6ec0a4a0 100644 > --- a/hw/arm/xlnx-versal.c > +++ b/hw/arm/xlnx-versal.c > @@ -376,6 +376,8 @@ static void versal_unimp(Versal *s) > MM_CRL, MM_CRL_SIZE); > versal_unimp_area(s, "crf", &s->mr_ps, > MM_FPD_CRF, MM_FPD_CRF_SIZE); > + versal_unimp_area(s, "apu", &s->mr_ps, > + MM_FPD_FPD_APU, MM_FPD_FPD_APU_SIZE); > versal_unimp_area(s, "crp", &s->mr_ps, > MM_PMC_CRP, MM_PMC_CRP_SIZE); > versal_unimp_area(s, "iou-scntr", &s->mr_ps, > diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h > index 22a8fa5d11..9b79051747 100644 > --- a/include/hw/arm/xlnx-versal.h > +++ b/include/hw/arm/xlnx-versal.h > @@ -167,6 +167,8 @@ struct Versal { > #define MM_IOU_SCNTRS_SIZE 0x10000 > #define MM_FPD_CRF 0xfd1a0000U > #define MM_FPD_CRF_SIZE 0x140000 > +#define MM_FPD_FPD_APU 0xfd5c0000 > +#define MM_FPD_FPD_APU_SIZE 0x100 > > #define MM_PMC_SD0 0xf1040000U > #define MM_PMC_SD0_SIZE 0x10000 >
diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c index fb776834f7..cb6ec0a4a0 100644 --- a/hw/arm/xlnx-versal.c +++ b/hw/arm/xlnx-versal.c @@ -376,6 +376,8 @@ static void versal_unimp(Versal *s) MM_CRL, MM_CRL_SIZE); versal_unimp_area(s, "crf", &s->mr_ps, MM_FPD_CRF, MM_FPD_CRF_SIZE); + versal_unimp_area(s, "apu", &s->mr_ps, + MM_FPD_FPD_APU, MM_FPD_FPD_APU_SIZE); versal_unimp_area(s, "crp", &s->mr_ps, MM_PMC_CRP, MM_PMC_CRP_SIZE); versal_unimp_area(s, "iou-scntr", &s->mr_ps, diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h index 22a8fa5d11..9b79051747 100644 --- a/include/hw/arm/xlnx-versal.h +++ b/include/hw/arm/xlnx-versal.h @@ -167,6 +167,8 @@ struct Versal { #define MM_IOU_SCNTRS_SIZE 0x10000 #define MM_FPD_CRF 0xfd1a0000U #define MM_FPD_CRF_SIZE 0x140000 +#define MM_FPD_FPD_APU 0xfd5c0000 +#define MM_FPD_FPD_APU_SIZE 0x100 #define MM_PMC_SD0 0xf1040000U #define MM_PMC_SD0_SIZE 0x10000
Add unimplemented APU mmio region to xlnx-versal for booting bare-metal guests built with standalone bsp published at: https://github.com/Xilinx/embeddedsw/tree/master/lib/bsp/standalone/src/arm/ARMv8/64bit Signed-off-by: Tong Ho <tong.ho@xilinx.com> --- hw/arm/xlnx-versal.c | 2 ++ include/hw/arm/xlnx-versal.h | 2 ++ 2 files changed, 4 insertions(+)