diff mbox series

target/mips: Remove duplicated check_cp1_enabled() calls in Loongson EXT

Message ID 20210816001031.1720432-1-f4bug@amsat.org
State New
Headers show
Series target/mips: Remove duplicated check_cp1_enabled() calls in Loongson EXT | expand

Commit Message

Philippe Mathieu-Daudé Aug. 16, 2021, 12:10 a.m. UTC 
We already call check_cp1_enabled() earlier in the "pre-conditions"
checks for GSLWXC1 and GSLDXC1 in gen_loongson_lsdc2() prologue.
Remove the duplicated calls.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/mips/tcg/translate.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Huacai Chen Aug. 16, 2021, 1:47 a.m. UTC | #1 
Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>

On Mon, Aug 16, 2021 at 8:10 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> We already call check_cp1_enabled() earlier in the "pre-conditions"
> checks for GSLWXC1 and GSLDXC1 in gen_loongson_lsdc2() prologue.
> Remove the duplicated calls.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/mips/tcg/translate.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c
> index 5b03545f099..268460d63ee 100644
> --- a/target/mips/tcg/translate.c
> +++ b/target/mips/tcg/translate.c
> @@ -4777,7 +4777,6 @@ static void gen_loongson_lsdc2(DisasContext *ctx, int rt,
>          break;
>  #endif
>      case OPC_GSLWXC1:
> -        check_cp1_enabled(ctx);
>          gen_base_offset_addr(ctx, t0, rs, offset);
>          if (rd) {
>              gen_op_addr_add(ctx, t0, cpu_gpr[rd], t0);
> @@ -4790,7 +4789,6 @@ static void gen_loongson_lsdc2(DisasContext *ctx, int rt,
>          break;
>  #if defined(TARGET_MIPS64)
>      case OPC_GSLDXC1:
> -        check_cp1_enabled(ctx);
>          gen_base_offset_addr(ctx, t0, rs, offset);
>          if (rd) {
>              gen_op_addr_add(ctx, t0, cpu_gpr[rd], t0);
> --
> 2.31.1
>
Philippe Mathieu-Daudé Aug. 25, 2021, 10:51 a.m. UTC | #2 
On 8/16/21 2:10 AM, Philippe Mathieu-Daudé wrote:
> We already call check_cp1_enabled() earlier in the "pre-conditions"
> checks for GSLWXC1 and GSLDXC1 in gen_loongson_lsdc2() prologue.
> Remove the duplicated calls.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/mips/tcg/translate.c | 2 --
>  1 file changed, 2 deletions(-)

Thanks, applied to mips-next.
diff mbox series

Patch

diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c
index 5b03545f099..268460d63ee 100644
--- a/target/mips/tcg/translate.c
+++ b/target/mips/tcg/translate.c
@@ -4777,7 +4777,6 @@  static void gen_loongson_lsdc2(DisasContext *ctx, int rt,
         break;
 #endif
     case OPC_GSLWXC1:
-        check_cp1_enabled(ctx);
         gen_base_offset_addr(ctx, t0, rs, offset);
         if (rd) {
             gen_op_addr_add(ctx, t0, cpu_gpr[rd], t0);
@@ -4790,7 +4789,6 @@  static void gen_loongson_lsdc2(DisasContext *ctx, int rt,
         break;
 #if defined(TARGET_MIPS64)
     case OPC_GSLDXC1:
-        check_cp1_enabled(ctx);
         gen_base_offset_addr(ctx, t0, rs, offset);
         if (rd) {
             gen_op_addr_add(ctx, t0, cpu_gpr[rd], t0);