| Message ID | 20210803193447.3946219-3-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry | expand |
On Tue, Aug 3, 2021 at 4:35 PM Cleber Rosa <crosa@redhat.com> wrote: > > The tests/acceptance directory is currently lacking a maintainer > entry, even though I've been performing that role (of course with help > from many others). Thus, its status is, even more now, Maintained. > > This also removes the currently broken Trello board link, which was > make unavailable unintentionally by a third party. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > MAINTAINERS | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
On 8/3/21 10:09 PM, Willian Rampazzo wrote: > On Tue, Aug 3, 2021 at 4:35 PM Cleber Rosa <crosa@redhat.com> wrote: >> >> The tests/acceptance directory is currently lacking a maintainer >> entry, even though I've been performing that role (of course with help >> from many others). Thus, its status is, even more now, Maintained. >> >> This also removes the currently broken Trello board link, which was >> make unavailable unintentionally by a third party. >> >> Signed-off-by: Cleber Rosa <crosa@redhat.com> >> --- >> MAINTAINERS | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> > > Reviewed-by: Willian Rampazzo <willianr@redhat.com> Willian you could send an extra patch to add yourself a R: tag. Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Wed, Aug 4, 2021 at 6:45 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > On 8/3/21 10:09 PM, Willian Rampazzo wrote: > > On Tue, Aug 3, 2021 at 4:35 PM Cleber Rosa <crosa@redhat.com> wrote: > >> > >> The tests/acceptance directory is currently lacking a maintainer > >> entry, even though I've been performing that role (of course with help > >> from many others). Thus, its status is, even more now, Maintained. > >> > >> This also removes the currently broken Trello board link, which was > >> make unavailable unintentionally by a third party. > >> > >> Signed-off-by: Cleber Rosa <crosa@redhat.com> > >> --- > >> MAINTAINERS | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> > > > > Reviewed-by: Willian Rampazzo <willianr@redhat.com> > > Willian you could send an extra patch to add yourself a R: tag. Ack!
Hi, On 8/3/21 4:34 PM, Cleber Rosa wrote: > The tests/acceptance directory is currently lacking a maintainer > entry, even though I've been performing that role (of course with help > from many others). Thus, its status is, even more now, Maintained. yay! > > This also removes the currently broken Trello board link, which was > make unavailable unintentionally by a third party. I can still access the link. Anyway, maybe we could migrate the cards (not everything, just those which still make sense) to the GitLab's Issues tracker? > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > MAINTAINERS | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Acked-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > > diff --git a/MAINTAINERS b/MAINTAINERS > index 37b1a8e442..d35b948e8d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile > F: tests/tcg/Makefile.include > > Acceptance (Integration) Testing with the Avocado framework > -W: https://trello.com/b/6Qi1pxVn/avocado-qemu > -R: Cleber Rosa <crosa@redhat.com> > +M: Cleber Rosa <crosa@redhat.com> > R: Philippe Mathieu-Daudé <philmd@redhat.com> > R: Wainer dos Santos Moschetta <wainersm@redhat.com> > -S: Odd Fixes > +S: Maintained > +F: tests/Makefile.include > F: tests/acceptance/ > > Documentation
On 03/08/2021 21.34, Cleber Rosa wrote: > The tests/acceptance directory is currently lacking a maintainer > entry, even though I've been performing that role (of course with help > from many others). Thus, its status is, even more now, Maintained. > > This also removes the currently broken Trello board link, which was > make unavailable unintentionally by a third party. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > MAINTAINERS | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 37b1a8e442..d35b948e8d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile > F: tests/tcg/Makefile.include > > Acceptance (Integration) Testing with the Avocado framework > -W: https://trello.com/b/6Qi1pxVn/avocado-qemu > -R: Cleber Rosa <crosa@redhat.com> > +M: Cleber Rosa <crosa@redhat.com> > R: Philippe Mathieu-Daudé <philmd@redhat.com> > R: Wainer dos Santos Moschetta <wainersm@redhat.com> > -S: Odd Fixes > +S: Maintained > +F: tests/Makefile.include Not sure whether we really should add tests/Makefile.include in this section, since there are only a couple of lines in there that are related to the "acceptance" tests... Anyway: Acked-by: Thomas Huth <thuth@redhat.com> Cleber, now that the freeze period is over, could you collect the related patches on the list and send a pull request? Thomas
diff --git a/MAINTAINERS b/MAINTAINERS index 37b1a8e442..d35b948e8d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile F: tests/tcg/Makefile.include Acceptance (Integration) Testing with the Avocado framework -W: https://trello.com/b/6Qi1pxVn/avocado-qemu -R: Cleber Rosa <crosa@redhat.com> +M: Cleber Rosa <crosa@redhat.com> R: Philippe Mathieu-Daudé <philmd@redhat.com> R: Wainer dos Santos Moschetta <wainersm@redhat.com> -S: Odd Fixes +S: Maintained +F: tests/Makefile.include F: tests/acceptance/ Documentation
The tests/acceptance directory is currently lacking a maintainer entry, even though I've been performing that role (of course with help from many others). Thus, its status is, even more now, Maintained. This also removes the currently broken Trello board link, which was make unavailable unintentionally by a third party. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)