From patchwork Sun Aug 1 23:41:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1512173 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=NyS1QGTb; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GdHkd3RRfz9sX5 for ; Mon, 2 Aug 2021 09:43:05 +1000 (AEST) Received: from localhost ([::1]:50034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAL6l-0002YZ-0X for incoming@patchwork.ozlabs.org; Sun, 01 Aug 2021 19:43:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAL5v-0002WW-Pk for qemu-devel@nongnu.org; Sun, 01 Aug 2021 19:42:11 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:34483) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAL5u-0003kL-EN for qemu-devel@nongnu.org; Sun, 01 Aug 2021 19:42:11 -0400 Received: by mail-wr1-x435.google.com with SMTP id h13so5817056wrp.1 for ; Sun, 01 Aug 2021 16:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nF2CPaID+VIHHyjgrg/yG4IgKh5kbi2GWmyHFcP4Gh4=; b=NyS1QGTbvNT1A496xSOlAv7v5TyTHcuKQEWXPuT5KDkTsVMg1iuVFs0eMa4nRkQ8nf L3iKqS/WLujpUC6V3fC7VPTOlFSbFtFTjjYahQretqjiPMBUAIy9gkZvz39bfdQkkauO IVZU/H749ZKAqGJwfFtbRgO2rliS4hyJMa2WbDP/Lh5UAYNGr0/5Lk1Ibab61H10ils/ 9slzpA1TWT3BdLJPg8Akaf0xFup93whqBwLveFM8NlishOrzJz3EJvl0h9wMXGfzdDMO QnMewp2TjN1YOLU9SkT5mFYBBrlUxYTrHO3w092CglKIwcqKKR0TSZ0Pt6SE1W1wWWUZ QARw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nF2CPaID+VIHHyjgrg/yG4IgKh5kbi2GWmyHFcP4Gh4=; b=FJVtEqjYw4qkNGkf4Fh7Zpp2VPGzqBTprs0jU+4PFHkGSPrkPtSZOB5VBogs9pEtFO T5yO4eNNe0p+UzHRESuJuBx1z8BplJxoewPJ2tzt/sd08pgR5oQViQJ/EGHzn2UmvWnX sWeQTFSsBTOnxSyovQzEUi3FO47xu1NPXJlMHDxYwMidwpa+7wihTZFJUaVIVox7YbnG SA30egPt/24KI3KgmxmZX63DjBptg0sjGhfrQdNQTfq2XF7cOt6lvqtOevIEN0at3aUB 5rA4U4H60tAbO6ZT+yHiq9N+QeWFGbM9dT5Plj+T+cJIBgKzsptHMSJwbg4PkwsroeAh dlwA== X-Gm-Message-State: AOAM533khb6QJ2E0mUNmLj7lLGUasNAhw2CZEFTrl9kchKy+d+SUGPq4 +479mZwJ6XfRImQYXuV36oBuuo+3gw7RnA== X-Google-Smtp-Source: ABdhPJxkS0gW73A5jvBmWmcVYCgTOH9/iIoiHGHioWrmRKPSzUZdpw87WBXNowYrRTtZHbEmY4K6YQ== X-Received: by 2002:adf:db85:: with SMTP id u5mr14538829wri.167.1627861328964; Sun, 01 Aug 2021 16:42:08 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id m64sm10052931wmm.41.2021.08.01.16.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Aug 2021 16:42:08 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-6.2 1/4] target/mips: Simpify PREF opcode Date: Mon, 2 Aug 2021 01:41:59 +0200 Message-Id: <20210801234202.3167676-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210801234202.3167676-1-f4bug@amsat.org> References: <20210801234202.3167676-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Aurelien Jarno , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" check_insn() checks for any bit in the set, and INSN_R5900 is just another bit added to the set. No need to special-case it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 34a96159d15..05efd25e29d 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -15738,12 +15738,8 @@ static bool decode_opc_legacy(CPUMIPSState *env, DisasContext *ctx) /* Treat as NOP. */ break; case OPC_PREF: - if (ctx->insn_flags & INSN_R5900) { - /* Treat as NOP. */ - } else { - check_insn(ctx, ISA_MIPS4 | ISA_MIPS_R1); - /* Treat as NOP. */ - } + check_insn(ctx, ISA_MIPS4 | ISA_MIPS_R1 | INSN_R5900); + /* Treat as NOP. */ break; /* Floating point (COP1). */