From patchwork Tue Jul 20 15:41:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1507631 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i7LK7Rcp; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GTjfr3yNFz9sRR for ; Wed, 21 Jul 2021 01:43:32 +1000 (AEST) Received: from localhost ([::1]:45696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5ru6-0000a2-6R for incoming@patchwork.ozlabs.org; Tue, 20 Jul 2021 11:43:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5rsr-0007mL-Sb for qemu-devel@nongnu.org; Tue, 20 Jul 2021 11:42:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56853) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5rsq-0004vY-Bt for qemu-devel@nongnu.org; Tue, 20 Jul 2021 11:42:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gVsmVb/ANphJ5S6TeR3I6otvtOxp3iNritQAJ9GWeeA=; b=i7LK7Rcpn2PV4GALn3fgfYdLynK92q5w/Ykd+18vQRB19uB+95LvooMNzsbhnmbDw6xsFY J7Jvcn5iFW7gFQ6PSQvgmP8gbNXuw8VeWeuAN2GH50Je5tzZKi3yit6s8C0N6Ce5Gje1OJ iQyGOPDfH6GPBQgdkm0qJPURG940AKI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-Ca-SjPkcPBKi_aXdEluAFw-1; Tue, 20 Jul 2021 11:42:10 -0400 X-MC-Unique: Ca-SjPkcPBKi_aXdEluAFw-1 Received: by mail-wr1-f72.google.com with SMTP id a4-20020a0560001884b02901401e436a18so10505670wri.21 for ; Tue, 20 Jul 2021 08:42:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gVsmVb/ANphJ5S6TeR3I6otvtOxp3iNritQAJ9GWeeA=; b=bcEvc6lQ5w7jyh0qEkVY0APngK4FORPvn6opVyH3YgGa9y5QBJAU62YrK6dF05p4jU lG1g0vJzhay1pLBMQhXDFXJwd05MuMHLWVr4HbY+nJkU12jiasPMpvpHUxHK3Lb8aiZ+ I3y8f3pL+KFdPCra87SR2MTOPAuViDuRYMa7nKA2wpGDldzwIYtbuVA3sNKK8kAYWWfu B30MxofxBe0ptkN25Mhf8GY2514kbz5BTWdmNIy2AnsuwLsFRy1XcTLO8uzcwe5xemPo hHTC20LJ34MnRbZsViK+nbhkKKioO955YNf11Lxn/SX6OiCntAsytYfo8ojbR5asVLZh iC4w== X-Gm-Message-State: AOAM530CvEYH5mtx5jjTjYtKFlaTgcowH+MvCEgoQ6mIYFroRSMXpauE H2ySYBUcsELl3FHmSRACLQjIg3/nAyiCzC2mytG2KDASWrvT11cF64o2Ccjh3B8VS2k77rS+wjl rd/3eyBbYoiCGPMfGj34T9CELAe2t4GcOci7bBvAkEIgdJfjwlz6O54FwrLNw3jAE X-Received: by 2002:a05:600c:22d8:: with SMTP id 24mr31861289wmg.157.1626795729101; Tue, 20 Jul 2021 08:42:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlYzqcxpa7L8cQPJUqD0oXsOL6CLPFZmqvGCI59zo3XJr8ThRCFW9dscya4hK4HM3mq2OnUw== X-Received: by 2002:a05:600c:22d8:: with SMTP id 24mr31861272wmg.157.1626795728838; Tue, 20 Jul 2021 08:42:08 -0700 (PDT) Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id u2sm2883016wmm.37.2021.07.20.08.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:08 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 06/17] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV Date: Tue, 20 Jul 2021 17:41:30 +0200 Message-Id: <20210720154141.3919817-7-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.474, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Paolo Bonzini , Bin Meng , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i], hd_table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive) include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive); Fix the correct symbol dependency to avoid build failure when deselecting some machines: /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_devs': hw/ide/pci.c:491: undefined reference to `ide_create_drive' Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig") Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210515173716.358295-3-philmd@redhat.com> Acked-by: John Snow --- hw/ide/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index 8e2c8934549..dd85fa3619f 100644 --- a/hw/ide/Kconfig +++ b/hw/ide/Kconfig @@ -8,7 +8,7 @@ config IDE_QDEV config IDE_PCI bool depends on PCI - select IDE_CORE + select IDE_QDEV config IDE_ISA bool