diff mbox series

[11/16] microvm: Drop dead error handling in microvm_machine_state_init()

Message ID 20210720125408.387910-12-armbru@redhat.com
State New
Headers show
Series Various error handling fixes and cleanups | expand

Commit Message

Markus Armbruster July 20, 2021, 12:54 p.m. UTC 
Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine
type".

Cc: Sergio Lopez <slp@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/i386/microvm.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Sergio Lopez July 20, 2021, 1:36 p.m. UTC | #1 
On Tue, Jul 20, 2021 at 02:54:03PM +0200, Markus Armbruster wrote:
> Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine
> type".
> 
> Cc: Sergio Lopez <slp@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hw/i386/microvm.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
> index aba0c83219..f257ec5a0b 100644
> --- a/hw/i386/microvm.c
> +++ b/hw/i386/microvm.c
> @@ -458,15 +458,10 @@ static void microvm_machine_state_init(MachineState *machine)
>  {
>      MicrovmMachineState *mms = MICROVM_MACHINE(machine);
>      X86MachineState *x86ms = X86_MACHINE(machine);
> -    Error *local_err = NULL;
>  
>      microvm_memory_init(mms);
>  
>      x86_cpus_init(x86ms, CPU_VERSION_LATEST);
> -    if (local_err) {
> -        error_report_err(local_err);
> -        exit(1);
> -    }
>  
>      microvm_devices_init(mms);
>  }
> -- 
> 2.31.1
> 

Reviewed-by: Sergio Lopez <slp@redhat.com>
Philippe Mathieu-Daudé July 20, 2021, 6:06 p.m. UTC | #2 
On 7/20/21 2:54 PM, Markus Armbruster wrote:
> Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine
> type".
> 
> Cc: Sergio Lopez <slp@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hw/i386/microvm.c | 5 -----
>  1 file changed, 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Pankaj Gupta July 20, 2021, 9:59 p.m. UTC | #3 
> Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine
> type".
>
> Cc: Sergio Lopez <slp@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hw/i386/microvm.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
> index aba0c83219..f257ec5a0b 100644
> --- a/hw/i386/microvm.c
> +++ b/hw/i386/microvm.c
> @@ -458,15 +458,10 @@ static void microvm_machine_state_init(MachineState *machine)
>  {
>      MicrovmMachineState *mms = MICROVM_MACHINE(machine);
>      X86MachineState *x86ms = X86_MACHINE(machine);
> -    Error *local_err = NULL;
>
>      microvm_memory_init(mms);
>
>      x86_cpus_init(x86ms, CPU_VERSION_LATEST);
> -    if (local_err) {
> -        error_report_err(local_err);
> -        exit(1);
> -    }
>
>      microvm_devices_init(mms);
>  }
> --
> 2.31.1

Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
diff mbox series

Patch

diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
index aba0c83219..f257ec5a0b 100644
--- a/hw/i386/microvm.c
+++ b/hw/i386/microvm.c
@@ -458,15 +458,10 @@  static void microvm_machine_state_init(MachineState *machine)
 {
     MicrovmMachineState *mms = MICROVM_MACHINE(machine);
     X86MachineState *x86ms = X86_MACHINE(machine);
-    Error *local_err = NULL;
 
     microvm_memory_init(mms);
 
     x86_cpus_init(x86ms, CPU_VERSION_LATEST);
-    if (local_err) {
-        error_report_err(local_err);
-        exit(1);
-    }
 
     microvm_devices_init(mms);
 }