Message ID | 20210714182056.25888-5-alex.bennee@linaro.org |
---|---|
State | New |
Headers | show |
Series | documentation and metadata updates | expand |
On 7/14/21 11:20 AM, Alex Bennée wrote: > It was pointed out in review of the previous patch that the if leg > isn't needed as the for loop will not enter on an empty $device_archs. > > Fixes: d1d5e9eefd ("configure: allow the selection of alternate config in the build") > Signed-off-by: Alex Bennée<alex.bennee@linaro.org> > Message-Id:<20210714093638.21077-5-alex.bennee@linaro.org> > --- > configure | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/configure b/configure index 4d0a2bfdd8..013f327f4a 100755 --- a/configure +++ b/configure @@ -5083,12 +5083,10 @@ if test "$skip_meson" = no; then echo "[properties]" >> $cross # unroll any custom device configs - if test -n "$device_archs"; then - for a in $device_archs; do - eval "c=\$devices_${a}" - echo "${a}-softmmu = '$c'" >> $cross - done - fi + for a in $device_archs; do + eval "c=\$devices_${a}" + echo "${a}-softmmu = '$c'" >> $cross + done test -z "$cxx" && echo "link_language = 'c'" >> $cross echo "[built-in options]" >> $cross
It was pointed out in review of the previous patch that the if leg isn't needed as the for loop will not enter on an empty $device_archs. Fixes: d1d5e9eefd ("configure: allow the selection of alternate config in the build") Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Message-Id: <20210714093638.21077-5-alex.bennee@linaro.org> --- configure | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)