diff mbox series

[19/41] target/microblaze: Use translator_use_goto_tb

Message ID	20210710153143.1320521-20-richard.henderson@linaro.org
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PATCH 19/41] target/microblaze: Use translator_use_goto_tb Date: Sat, 10 Jul 2021 08:31:21 -0700 Message-Id: <20210710153143.1320521-20-richard.henderson@linaro.org> In-Reply-To: <20210710153143.1320521-1-richard.henderson@linaro.org> References: <20210710153143.1320521-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Cc: Peter Maydell <peter.maydell@linaro.org> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	[01/41] tcg: Add separator in INDEX_op_call dump \| expand [01/41] tcg: Add separator in INDEX_op_call dump [02/41] tcg: Avoid including 'trace-tcg.h' in target translate.c [03/41] accel/tcg: Hoist tcg_tb_insert() up above tb_link_page() [04/41] tcg: Bake tb_destroy() into tcg_region_tree [05/41] tcg: Move tb_phys_invalidate_count to tb_ctx [06/41] accel/tcg: Introduce translator_use_goto_tb [07/41] target/alpha: Remove use_exit_tb [08/41] target/alpha: Remove in_superpage [09/41] target/alpha: Use translator_use_goto_tb [10/41] target/arm: Use DISAS_TOO_MANY for ISB and SB [11/41] target/arm: Use translator_use_goto_tb for aarch64 [12/41] target/arm: Use translator_use_goto_tb for aarch32 [13/41] target/avr: Use translator_use_goto_tb [14/41] target/avr: Mark some helpers noreturn [15/41] target/cris: Use translator_use_goto_tb [16/41] target/hppa: Use translator_use_goto_tb [17/41] target/i386: Use translator_use_goto_tb [18/41] target/m68k: Use translator_use_goto_tb [19/41] target/microblaze: Use translator_use_goto_tb [20/41] target/mips: Use translator_use_goto_tb [21/41] target/mips: Fix missing else in gen_goto_tb [22/41] target/nios2: Use translator_use_goto_tb [23/41] target/openrisc: Use translator_use_goto_tb [24/41] target/ppc: Use translator_use_goto_tb [25/41] target/riscv: Use translator_use_goto_tb [26/41] target/rx: Use translator_use_goto_tb [27/41] target/s390x: Use translator_use_goto_tb [28/41] target/s390x: Remove use_exit_tb [29/41] target/sh4: Use translator_use_goto_tb [30/41] target/sparc: Use translator_use_goto_tb [31/41] target/tricore: Use translator_use_goto_tb [32/41] target/tricore: Use tcg_gen_lookup_and_goto_ptr [33/41] target/xtensa: Use translator_use_goto_tb [34/41] tcg: Fix prologue disassembly [35/41] target/i386: Use cpu_breakpoint_test in breakpoint_handler [36/41] accel/tcg: Move helper_lookup_tb_ptr to cpu-exec.c [37/41] accel/tcg: Move tb_lookup to cpu-exec.c [38/41] accel/tcg: Split out log_cpu_exec [39/41] accel/tcg: Log tb->cflags with -d exec [40/41] tcg: Remove TCG_TARGET_HAS_goto_ptr [41/41] cpu: Add breakpoint tracepoints

Commit Message

Richard Henderson July 10, 2021, 3:31 p.m. UTC

Just use translator_use_goto_tb directly at the one call site,
rather than maintaining a local wrapper.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/microblaze/translate.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff mbox series

Patch

diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 5dfb08d49f..c68a84a219 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -124,15 +124,6 @@  static void gen_raise_hw_excp(DisasContext *dc, uint32_t esr_ec)
     gen_raise_exception_sync(dc, EXCP_HW_EXCP);
 }
 
-static inline bool use_goto_tb(DisasContext *dc, target_ulong dest)
-{
-#ifndef CONFIG_USER_ONLY
-    return (dc->base.pc_first & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK);
-#else
-    return true;
-#endif
-}
-
 static void gen_goto_tb(DisasContext *dc, int n, target_ulong dest)
 {
     if (dc->base.singlestep_enabled) {
@@ -140,7 +131,7 @@  static void gen_goto_tb(DisasContext *dc, int n, target_ulong dest)
         tcg_gen_movi_i32(cpu_pc, dest);
         gen_helper_raise_exception(cpu_env, tmp);
         tcg_temp_free_i32(tmp);
-    } else if (use_goto_tb(dc, dest)) {
+    } else if (translator_use_goto_tb(&dc->base, dest)) {
         tcg_gen_goto_tb(n);
         tcg_gen_movi_i32(cpu_pc, dest);
         tcg_gen_exit_tb(dc->base.tb, n);