diff mbox series

[v5,02/16] python: Reduce strictness of pylint's duplicate-code check

Message ID 20210604091723.13419-3-eesposit@redhat.com
State New
Headers show
Series qemu_iotests: improve debugging options | expand

Commit Message

Emanuele Giuseppe Esposito June 4, 2021, 9:17 a.m. UTC 
From: John Snow <jsnow@redhat.com>

Pylint prior to 2.8.3 (We pin at >= 2.8.0) includes function and method
signatures as part of its duplicate checking algorithm. This check does
not listen to pragmas, so the only way to disable it is to turn it off
completely or increase the minimum duplicate lines so that it doesn't
trigger for functions with long, multi-line signatures.

When we decide to upgrade to pylint 2.8.3 or greater, we will be able to
use 'ignore-signatures = true' to the config instead.

I'd prefer not to keep us on the very bleeding edge of pylint if I can
help it -- 2.8.3 came out only three days ago at time of writing.

See: https://github.com/PyCQA/pylint/pull/4474
Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/setup.cfg | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Vladimir Sementsov-Ogievskiy June 5, 2021, 1:30 p.m. UTC | #1 
04.06.2021 12:17, Emanuele Giuseppe Esposito wrote:
> From: John Snow<jsnow@redhat.com>
> 
> Pylint prior to 2.8.3 (We pin at >= 2.8.0) includes function and method
> signatures as part of its duplicate checking algorithm. This check does
> not listen to pragmas, so the only way to disable it is to turn it off
> completely or increase the minimum duplicate lines so that it doesn't
> trigger for functions with long, multi-line signatures.
> 
> When we decide to upgrade to pylint 2.8.3 or greater, we will be able to
> use 'ignore-signatures = true' to the config instead.
> 
> I'd prefer not to keep us on the very bleeding edge of pylint if I can
> help it -- 2.8.3 came out only three days ago at time of writing.
> 
> See:https://github.com/PyCQA/pylint/pull/4474
> Signed-off-by: John Snow<jsnow@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
diff mbox series

Patch

diff --git a/python/setup.cfg b/python/setup.cfg
index 0fcdec6f32..d82c39aa46 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -78,6 +78,11 @@  good-names=i,
 # Ignore imports when computing similarities.
 ignore-imports=yes
 
+# Minimum lines number of a similarity.
+# TODO: Remove after we opt in to Pylint 2.8.3. See commit msg.
+min-similarity-lines=6
+
+
 [isort]
 force_grid_wrap=4
 force_sort_within_sections=True