| Message ID | 20210517115525.1088693-11-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | softmmu: Make various objects target agnostic | expand |
Forgot to Cc Alex... On 5/17/21 1:55 PM, Philippe Mathieu-Daudé wrote: > gdb_exit() and gdb_set_stop_cpu() prototypes don't have to be > target specific. Remove this limitation to be able to build > softmmu/cpus.c and softmmu/runstate.c once for all targets. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > include/exec/gdbstub.h | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h > index a024a0350df..84b1f2ff2aa 100644 > --- a/include/exec/gdbstub.h > +++ b/include/exec/gdbstub.h > @@ -45,17 +45,6 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const char *fmt, ...); > */ > void gdb_do_syscallv(gdb_syscall_complete_cb cb, const char *fmt, va_list va); > int use_gdb_syscalls(void); > -void gdb_set_stop_cpu(CPUState *cpu); > - > -/** > - * gdb_exit: exit gdb session, reporting inferior status > - * @code: exit code reported > - * > - * This closes the session and sends a final packet to GDB reporting > - * the exit status of the program. It also cleans up any connections > - * detritus before returning. > - */ > -void gdb_exit(int code); > > #ifdef CONFIG_USER_ONLY > /** > @@ -177,6 +166,18 @@ static inline uint8_t * gdb_get_reg_ptr(GByteArray *buf, int len) > */ > int gdbserver_start(const char *port_or_device); > > +/** > + * gdb_exit: exit gdb session, reporting inferior status > + * @code: exit code reported > + * > + * This closes the session and sends a final packet to GDB reporting > + * the exit status of the program. It also cleans up any connections > + * detritus before returning. > + */ > +void gdb_exit(int code); > + > +void gdb_set_stop_cpu(CPUState *cpu); > + > /** > * gdb_has_xml: > * This is an ugly hack to cope with both new and old gdb. >
On 5/17/21 4:55 AM, Philippe Mathieu-Daudé wrote: > gdb_exit() and gdb_set_stop_cpu() prototypes don't have to be > target specific. Remove this limitation to be able to build > softmmu/cpus.c and softmmu/runstate.c once for all targets. > > Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org> > --- > include/exec/gdbstub.h | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index a024a0350df..84b1f2ff2aa 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -45,17 +45,6 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const char *fmt, ...); */ void gdb_do_syscallv(gdb_syscall_complete_cb cb, const char *fmt, va_list va); int use_gdb_syscalls(void); -void gdb_set_stop_cpu(CPUState *cpu); - -/** - * gdb_exit: exit gdb session, reporting inferior status - * @code: exit code reported - * - * This closes the session and sends a final packet to GDB reporting - * the exit status of the program. It also cleans up any connections - * detritus before returning. - */ -void gdb_exit(int code); #ifdef CONFIG_USER_ONLY /** @@ -177,6 +166,18 @@ static inline uint8_t * gdb_get_reg_ptr(GByteArray *buf, int len) */ int gdbserver_start(const char *port_or_device); +/** + * gdb_exit: exit gdb session, reporting inferior status + * @code: exit code reported + * + * This closes the session and sends a final packet to GDB reporting + * the exit status of the program. It also cleans up any connections + * detritus before returning. + */ +void gdb_exit(int code); + +void gdb_set_stop_cpu(CPUState *cpu); + /** * gdb_has_xml: * This is an ugly hack to cope with both new and old gdb.
gdb_exit() and gdb_set_stop_cpu() prototypes don't have to be target specific. Remove this limitation to be able to build softmmu/cpus.c and softmmu/runstate.c once for all targets. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- include/exec/gdbstub.h | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-)